pfalcon commented 4 years ago

There was a typo in RecursiveDescentParser class which was fixed yet in fea94c52f26d.

Signed-off-by: Paul Sokolovsky pfalcon@users.sourceforge.net

pfalcon commented 4 years ago

This shows that it's unfortunate that llvmir package is not under CI. There's a test in the testsuite, but it's all @skip. It would be nice to at least exercise LLVM IR parser to avoid cases like this.

codecov-io commented 4 years ago

Codecov Report

Merging #117 into master will increase coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   78.97%   78.98%   +0.01%     
==========================================
  Files         353      353              
  Lines       47323    47310      -13     
==========================================
- Hits        37371    37370       -1     
+ Misses       9952     9940      -12

Impacted Files	Coverage Δ
ppci/lang/llvmir/parser.py	`12.54% <0.00%> (ø)`
ppci/wasm/components.py	`81.37% <0.00%> (-0.29%)`	:arrow_down:
ppci/wasm/util.py	`39.13% <0.00%> (+0.42%)`	:arrow_up:
ppci/binutils/dbg/gdb/client.py	`53.57% <0.00%> (+0.42%)`	:arrow_up:
ppci/binutils/dbg/debugger.py	`88.23% <0.00%> (+0.64%)`	:arrow_up:
ppci/arch/riscv/registers.py	`94.00% <0.00%> (+0.93%)`	:arrow_up:
ppci/arch/mips/instructions.py	`87.68% <0.00%> (+1.55%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e41cbc2...136dab9. Read the comment docs.

pfalcon commented 4 years ago

@windelbouwman: Ping?

windelbouwman commented 4 years ago

Ack

windelbouwman / ppci

lang.llvmir.parser: Fix typo in .peek attribute (was .peak). #117

Codecov Report