search

windelbouwman / ppci

A compiler for ARM, X86, MSP430, xtensa and more implemented in pure Python
https://ppci.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
337 stars 36 forks source link

Does this project have any commit guidelines/rules? #5

Open pfalcon opened 5 years ago

pfalcon commented 5 years ago

The project is absolutely great, I don't know how I missed it previously (I'm aware of https://github.com/ShivamSarodia/ShivyC for example).

But looking at the commit history to get an idea of what's happening, I'm somewhat concerned if there's good enough change control. E.g., the latest commit as of now, https://github.com/windelbouwman/ppci-mirror/commit/cd692923282561219fc4cff994a1bd3fdde4cb6d is described as "Change C string literal type to array of char.", but contains changes to "with 469 additions and 267 deletions", with some changes clearly have nothing to do with "Change C string literal type to array of char", e.g., changes to .hgignore, docs, etc.

So, are there guidelines/rules being followed by the project in that regard? While there's pretty detailed https://ppci.readthedocs.io/en/latest/contributing.html section in the docs, I don't see that matter covered there.

(I apologize in advance if that's not the kind of question the maintainers interested to discuss. OTOH, I may assure it would be of the utter importance to (some) contributors ;-) ).

windelbouwman commented 5 years ago

There are no strict commit message guidelines. I worked mostly on this alone, with two other people so far, so I did not pay very close attention to proper commit messages, but just commited bundles of work from time to time.

Btw, shivyc is nice, but it does only support x86_64 as far as I know. ppci supports multiple architectures including wasm.