search

winder / Universal-G-Code-Sender

A cross-platform G-Code sender for GRBL, Smoothieware, TinyG and G2core.
http://winder.github.io/ugs_website/
GNU General Public License v3.0
1.89k stars 764 forks source link

These are not used in the visualizer. #1302

Open zachari043 opened 4 years ago

zachari043 commented 4 years ago 
    // These are not used in the visualizer.
        case G54:
        case G55:
        case G56:
        case G57:
        case G58:
        case G59:
        case G59_1:
        case G59_2:
        case G59_3:
            state.offset = code;
            break;

It's an error when no zero point is fixed it must drow visualisation from machine zero G53 but if you set G54, draw must done from G54 point and then G53 commands must be drown away from G54 by his offset values, this is mutch more correct and close to professionnal machines

G53, in visualizer like in the machine must be absolute référence, it is omitted here G53 is important and it shall be visible on visualizer

breiler commented 4 years ago

If I understand you correctly, the issue #1108 is also related? How should this work if the user hasn't setup homing and the machine coordinates aren't known?