search

windicss / windicss-intellisense

Intelligent WindiCSS tooling for VS Code
https://marketplace.visualstudio.com/items?itemName=voorjaar.windicss-intellisense
MIT License
194 stars 16 forks source link

class string formatting conflict occurs after sortOnSave is enabled #297

Open zhou-tao opened 2 years ago

zhou-tao commented 2 years ago

When I enable sortOnSave, then using variant-groups to pass two or more properties inside parentheses: A space is automatically appended to the end of the line

image

But it didn't happen after I tried to pass only one property, like this:

image

hope it can be resolved! thanks

kansson commented 2 years ago

This is happening for me as well with v0.21.6.

kansson commented 2 years ago

Hi again, the auto sort does not work in variant groups either.

alexanderniebuhr commented 2 years ago

you can also track https://github.com/alexanderniebuhr/prettier-plugin-unocss (which I would call the windi css version)

lucperkins commented 1 year ago

@alexanderniebuhr Why are you closing issues related to this? This is a problem that I'm having with the plugin as well. Saying that PRs are welcome is a perfectly reasonable response in open source, but closing the issue as completed sends the signal that the issue has been addressed.

alexanderniebuhr commented 1 year ago

@lucperkins I closed this, because the plan is to drop the current implementation in favour of something new. But I will reopen this, and let other people contribute if they thing they can fix the current implementation.

Vexcited commented 1 year ago

Also had issues with sortOnSave where it just removes some classes from the parenthesis, as you can see in this commit :

image

This led to some hours of understanding "why my elements aren't looking like they were before" :sob: