windingwind / zotero-actions-tags

Customize your Zotero workflow.
GNU Affero General Public License v3.0
1.94k stars 48 forks source link

[Bug] Trigger Other Actions doesnot work for certain actions #333

Closed ramonmi closed 5 months ago

ramonmi commented 5 months ago

Is there an existing issue for this?

Are you using the latest Zotero and the latest plugin?

Environment

Describe the bug

I add two actions in the Data (without quotes) but nothing happens when I trigger this action. Same as FeralFlora‘s description even using the latest plugin. https://github.com/windingwind/zotero-actions-tags/discussions/169#discussioncomment-9690342 However, at least, the Format Chinese Annotations action can be triggered by the parent action.

Debug Output

(3)(+0000001): [Actions and Tags for Zotero] applyAction {"event":0,"operation":4,"data":"/*\n Toggle Left Pane\n @author MuiseDestiny, windingwind\n @usage Assign a shortcut\n @link https://github.com/windingwind/zotero-actions-tags/discussions/169\n @see https://github.com/windingwind/zotero-actions-tags/discussions/169\n */\nconst Zotero = require(\"Zotero\");\nconst Zotero_Tabs = require(\"Zotero_Tabs\");\nconst document = require(\"document\");\n\nif (item) {\n return;\n}\n\nif (Zotero_Tabs.selectedType === \"library\") {\n const splitter = document.querySelector(\"#zotero-collections-splitter\");\n if (splitter.getAttribute(\"state\") == \"collapsed\") {\n splitter.setAttribute(\"state\", \"\");\n return;\n } else {\n splitter.setAttribute(\"state\", \"collapsed\");\n return;\n }\n} else {\n Zotero.Reader.getByTabID(\n Zotero_Tabs.selectedID\n )._internalReader.toggleSidebar();\n return;\n}","shortcut":"Ctrl,Alt,4","enabled":true,"menu":"","name":"Toggle Left Pane","showInMenu":{"item":false,"collection":false,"tools":false,"reader":false,"readerAnnotation":false}} {"itemID":7199,"triggerType":"shortcut"}

BTW, The Debug output is the same as the output when trigger the origin Toggle Left Pane action.

Anything else?

No response

windingwind commented 5 months ago

Could you please take a screenshot of your actions list?

ramonmi commented 5 months ago

Could you please take a screenshot of your actions list?

At least, the Attach File https://github.com/windingwind/zotero-actions-tags/discussions/290, and Copy Zotero link https://github.com/windingwind/zotero-actions-tags/discussions/290 are also not working. But the Rename attachment https://github.com/windingwind/zotero-actions-tags/discussions/291 is normal. So it may relate to the script itself.

windingwind commented 5 months ago

yes, please make sure you can run the sub-actions separately.

ramonmi commented 5 months ago

yes, please make sure you can run the sub-actions separately.

Yes, I can confirm that they can all run independently. I have been using them for a long time.

github-actions[bot] commented 5 months ago

:rocket: This ticket has been resolved in v1.0.0-beta.44. See Release v1.0.0-beta.44 for release notes.