search

windingwind / zotero-types

TypeScript definitions for Zotero.
https://www.npmjs.com/package/zotero-types
MIT License
56 stars 9 forks source link

Update XUL popup definition #50

Closed Dominic-DallOsto closed 4 weeks ago

Dominic-DallOsto commented 1 month ago

I combined the descriptions from the docs here with the source code here with a test of the available properties in Zotero's debud console.

Basically, the showPopup method doesn't exist anymore, and was replaced by different openPopup... methods

windingwind commented 1 month ago

We already have a XULPopupElement from the gecko definition, could reuse that

windingwind commented 1 month ago

https://github.com/windingwind/zotero-types/blob/5d12442efc8c7cd885c96a2aaa93d82ef61b2d88/types/gecko/lib.gecko.dom.d.ts#L42467

windingwind commented 1 month ago

Actually, I think we should refactor how we define XUL elements in xul.d.ts to align with the approach used in lib.gecko.dom.d.ts.

Dominic-DallOsto commented 1 month ago

That makes sense!

windingwind commented 4 weeks ago

I've updated the xul.d.ts. Thanks!

Dominic-DallOsto commented 4 weeks ago

Ahh, sorry for the delay but thanks!