search

windkh / node-red-contrib-telegrambot

Telegram bot nodes for node-red.
Other
266 stars 119 forks source link

Option saveDataDir: How does it works? #125

Closed StephanStS closed 4 years ago

StephanStS commented 4 years ago

In the description there is an option saveDataDir. In the Configuration Node there is no property to set this value. How can it be set?

BTW: I have forked the node and will work on some documentation rework/enhancement. I then will issue a pull request if I am finished.

windkh commented 4 years ago

It is a property in the receiver node

windkh commented 4 years ago

Yes the description should be under the receiver node instead of the configuration node... I will fix this

StephanStS commented 4 years ago

I am working on the docu rework, so you can lean back and wait for my pull request of Readme.md. I now understand the functionality.

windkh commented 4 years ago

So what are you going to rework? I am curious...

StephanStS commented 4 years ago

I want to do some enhancements to the documentation: Beautifications, clearifications, typos, etc. No big changes.

windkh commented 4 years ago

Thanks in advance...

StephanStS commented 4 years ago

As an example compare https://github.com/eschava/node-red-contrib-hourglass/tree/01ac5646ba5ffa9d95dcecfca11f5d666676847e with https://github.com/eschava/node-red-contrib-hourglass :-)

Barabba11 commented 4 years ago

Precious work!

StephanStS commented 4 years ago

You can "follow" the work on https://github.com/StephanStS/node-red-contrib-telegrambot.

ozett commented 4 years ago

do you keep all the config-information in this over-long readme.md? difficult to scroll and jump from top to bottom because all infos only on this one page..

why dont you do this (like most others) in a structured wiki on github?

StephanStS commented 4 years ago

I am not familiar with a structured wiki, so the only think I can do would be to insert an table of contents on the top of the page.

In another case (node-red-contrib-finite-statemachine) we divided the Readme.md into a short version and a longer Manual.md. This could also be an option. @windkh: What is your proposal to go on?

windkh commented 4 years ago

do you keep all the config-information in this over-long readme.md? difficult to scroll and jump from top to bottom because all infos only on this one page..

why dont you do this (like most others) in a structured wiki on github?

Well, because it grew over time and moving it into a wiki is time consuming.... if anyone would do this I would be glad

windkh commented 4 years ago

I am not familiar with a structured wiki, so the only think I can do would be to insert an table of contents on the top of the page.

In another case (node-red-contrib-finite-statemachine) we divided the Readme.md into a short version and a longer Manual.md. This could also be an option. @windkh: What is your proposal to go on?

Just add your changes to the existing readme... maybe I will open a wiki in future