windler / ws

cli app to list your workspaces, git branch info and custom information
MIT License
6 stars 0 forks source link

Customcommands not working with apps like vi #4

Closed windler closed 6 years ago

windler commented 6 years ago

Apps like vior vim do not work with CustomCommands, because they need a proper terminal.

Thanks @tylerfowle for adressing this issue.

windler commented 6 years ago

@tylerfowle could you try your config with the current master?

tylerfowle commented 6 years ago

@windler still not working, it just hangs on ws code ws 😞

windler commented 6 years ago

Strange, I tested it with vi and nvim and it worked after these changes. Whats your OS and Terminal app?

tylerfowle commented 6 years ago

@windler using macos 10.12.6 with iTerm2 Build 3.2.0beta6

tylerfowle commented 6 years ago

@windler it also hangs in Terminal.app

windler commented 6 years ago

@tylerfowle I tried macos + iTerm and it works for me. Are you sure you executed go get -u github.com/windler/ws? The -u flag is necessary.

tylerfowle commented 6 years ago

@windler ah yes, it is working now!

windler commented 6 years ago

Great to hear that!