search

windmill-labs / windmill-helm-charts

50 stars 34 forks source link

Global labels & annotations #58

Closed MikeAtJulaya closed 8 months ago

MikeAtJulaya commented 8 months ago

Hi team 👋🏼

It would be nice to have a global rewriting of labels and annotations on top. Cause on my IDP (Qovery) there are some missing and I can't:

For example:

windmill:
    annotations:
      qovery.annotations.service
    labels:
      qovery.labels.service

I'm available for testing if needed 👌🏼 cheers 🍻

rubenfiszel commented 8 months ago

Hi, you can override those for every services (app, workers, lsp, ingress) so it does seem like it is currently supported but require a bit more text than you would want?

MikeAtJulaya commented 8 months ago

@rubenfiszel thx 🙏🏼 I have already overridden for every services. Usually with other Helm charts all is good when annotation and labels are overridden, it's only happen with Windmill. Maybe I need to see that to with Qovery too

rubenfiszel commented 8 months ago

See https://github.com/windmill-labs/windmill-helm-charts/issues/59#issuecomment-1948405081

MikeAtJulaya commented 8 months ago

@rubenfiszel I am sooooo dumb All my apologies an great thanks to you for pointing my mistake 🙏🏼