search

windmill-labs / windmill

Open-source developer platform to power your entire infra and turn scripts into webhooks, workflows and UIs. Fastest workflow engine (13x vs Airflow). Open-source alternative to Retool and Temporal.
https://windmill.dev
Other
9.69k stars 444 forks source link

bug: Added Google SSO to Self Hosted instance but no option to login via Google when opening in incognito #3696

Open jacobburrell opened 4 months ago

jacobburrell commented 4 months ago

Describe the bug

Google Login tutorial seems to indicate the option to login should be available after assigning the client ID and secret, but no option to login via Google exists after saving credentials.

To reproduce

Setup

image image

Expected behavior

The option to login via Google should be available.

Screenshots

No response

Browser information

Chrome Version 124.0.6367.119 (Official Build) (x86_64)

Application version

Windmill CE v1.321.4

Additional Context

No response

rubenfiszel commented 4 months ago

@jacobburrell sorry for slow response but did you save the settings after puttin the clientId/secret?

rubenfiszel commented 4 months ago

Other possibility is that you built windmill from sources or are not using our community edition image. SSO requires proprietary features that we provide for free (up to 10 users) in the community image

jacobburrell commented 4 months ago

@rubenfiszel I am playing around with Caprover and deployed with their one-click app marketplace:

image

Looks like it pulls from Releases or Packages

I did save.

image

What logs can I get you to help diagnose?

rubenfiszel commented 4 months ago

That's a pretty old release, could you try with the latest release please

jacobburrell commented 4 months ago

Hi @rubenfiszel the version in the screenshot is not the version I am running, I put a more up-to-date version when deploying. The version in the screenshot is just a placeholder placed when showing that screen.

Please see version listed. I will try with latest v1.332.0 but I am already running Windmill CE v1.321.4

mnbro commented 4 months ago

@jacobburrell I had the same issue with a new install of 1.1337.0. I downgraded to to 1.1336.1 and the SSO screen appeared. After this I came back to 1.1337.0 and SSO screen was also present there :).

So, I think you only have to stop/start your stack/containers and SSO will be present.

jacobburrell commented 3 months ago

@mnbro Just tried restarting the windmill-server container and the SSO option appeared.

Still should be part of docs, not necessary, etc rather than not working.

superjcvd commented 2 weeks ago

Other possibility is that you built windmill from sources or are not using our community edition image. SSO requires proprietary features that we provide for free (up to 10 users) in the community image

So If I understand well building the image from Github directly will lack the SSO features ? (I encountered this issue yesterday and that makes sense)

rubenfiszel commented 2 weeks ago

That's correct

On Wed, Sep 4, 2024 at 9:37 AM superjcvd @.***> wrote:

Other possibility is that you built windmill from sources or are not using our community edition image. SSO requires proprietary features that we provide for free (up to 10 users) in the community image

So If I understand well building the image from Github directly will lack the SSO features ? (I encountered this issue yesterday and that makes sense)

— Reply to this email directly, view it on GitHub https://github.com/windmill-labs/windmill/issues/3696#issuecomment-2328135755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDJAG6MDPVKVUSG55VV6TZU22E7AVCNFSM6AAAAABHONF5EKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYGEZTKNZVGU . You are receiving this because you were mentioned.Message ID: @.***>