search

window-maker / wmaker

Mirror of the official repository repo.or.cz/wmaker-crm.git. Do not send pull requests here, send your patches to wmaker-dev@googlegroups.com instead
https://repo.or.cz/wmaker-crm.git
GNU General Public License v2.0
136 stars 18 forks source link

icons resetting #1

Closed brightersun99 closed 3 years ago

brightersun99 commented 4 years ago

I am running the latest windowmaker.

I have some icons saved to my dock/clip, for launching things. I have set their icons to custom icons

And it works until I launch the program, then it reverts back to its original icon. Right clicking and editing it shows the path is still set to my custom icon, I can change it and it will still revert again until I do something with that program.

Seems this has been a bug since around 2004, fix it please?

gryf commented 4 years ago

There are two different things - icons for docked things before launch and the one programs owns.

So I assume, you've been dragged xterm (let's make it an example) to the dock, and there change the icon using this option in docked item settings:

Untitled and the icon on the dock would for example look like: Untitled2 but after double click on it you will end up with Xterm icon replacing the one specified previously: 3 and well. After killing/closing xterm, your defined icon on dock should appear again :)

And that's perfectly fine, because this option is for specifying an dock icon for windowless/iconless actions (like - launching some bash scripts, reload services etc). But you are probably launch a program which have a window and defined icon. To achieve what you want (aligned icon between program and icon on dock), here are the steps:

And it should work :)

brightersun99 commented 4 years ago

Thank you, you are awesome. I would have never found such an estoeric fix without your assistance, Thanks again.

gryf commented 4 years ago

Perhaps we should adapt this to the docs (as a FAQ/Note or whatever).

crmafra commented 4 years ago

On Thu, 10 Sep 2020 at 8:28:40 -0700, Roman Dobosz wrote:

Perhaps we should adapt this to the docs (as a FAQ/Note or whatever).

Good idea. Would you like to write a patch to the window maker homepage?

https://github.com/window-maker/window-maker.github.io

gryf commented 4 years ago

@crmafra I've filled an issue for it https://github.com/window-maker/window-maker.github.io/issues/11 just to not forget :)

brightersun99 commented 4 years ago

There are two different things - icons for docked things before launch and the one programs owns.

So I assume, you've been dragged xterm (let's make it an example) to the dock, and there change the icon using this option in docked item settings:

Untitled and the icon on the dock would for example look like: Untitled2 but after double click on it you will end up with Xterm icon replacing the one specified previously: 3 and well. After killing/closing xterm, your defined icon on dock should appear again :)

And that's perfectly fine, because this option is for specifying an dock icon for windowless/iconless actions (like - launching some bash scripts, reload services etc). But you are probably launch a program which have a window and defined icon. To achieve what you want (aligned icon between program and icon on dock), here are the steps:

  • run the xterm (we are still using xterm as an example)
  • right click on the xterm titlebar to pop up window menu
  • select attributes
  • from option menu on top select "icon and initial workspace"
  • browse for desired icon
  • don't forget to tick checkbox "ignore client supplied icon"
  • apply + save
  • drag from clip to dock (or alternatively right click on icon which is attracted to clip, select "keep icon")

And it should work :)

It seems my issue, while less frequent still exists, more or less for some programs.

For example, my terminal now behaves most of the time, but still rarely it reverts to its old icon. Seamonkey on the other hand is very aggressive about keeping its old icon and the fix does not work for it at all. Do you have any other ideas? I was thinking I could write a wrapper that launched their respective programs with ONLY the icon I want

gryf commented 4 years ago

The only thing I can think of is that it is connected with saving session. Do you use saving session for wmaker? Do you have any other program, which behave that way as seamonky? And finally: perhaps starting up wmaker with fresh configuration might help to reveal the root cause of the issue.

brightersun99 commented 4 years ago

Hi, been messing with this. I did a fresh slate. new install of my distro and everything, so the icon for seamonkey couldn't have been cached. Just to be safe, I replaced all variants of seamonkeys original icon with my own. I started seamonkey, added it to my dock and applied ignore client icon. But while its running it aggressivly maintains its own icon, I don't know where it gets it from! I thought I deleted or overwrote every distance of them and evne made them write protected.. I start with a fresh session each time, I do not have any session saving but to debug that anyways Ive been doing fresh configs and wiping all saved states when testing things.

gryf commented 4 years ago

Perhaps this is strictly connected with Seamonkey, which might happen to manage its own icon by itself. Do you observe such a behavior on other programs as well? Can you provide the names?

brightersun99 commented 4 years ago

xpaint is another example.

gryf commented 4 years ago

I have tested steps described above with xpaint-2.10.2 and it's seems to work. Icon firmly stays changed.

gryf commented 3 years ago

Didn't hear from @brightersun99 about this issue for couple of months now. I guess we can close it, otherwise it could be reopened. Note, that documentation issue is under another repo.