window-maker / wmaker

Mirror of the official repository repo.or.cz/wmaker-crm.git. Do not send pull requests here, send your patches to wmaker-dev@googlegroups.com instead
https://repo.or.cz/wmaker-crm.git
GNU General Public License v2.0
124 stars 18 forks source link

[feature request] Option to keep the dock on primary screen #24

Closed kugelblitz closed 1 year ago

kugelblitz commented 1 year ago

Hello,

Thank you for supporting WindowMaker.

I have the dock attached to the right border of the screen. I also have a second monitor which is configured via XRandR to be on the right side of my primary monitor. This causes the dock to move to the second monitor and attach to its right border because it seeks to be on the right border of the "whole" merged screen. This is not always wanted, not in my case.

It would be great to have the option to keep the Dock on primary screen.

tstraus13 commented 1 year ago

Just figured I'd chime in here too. I am liking WindowMaker but I have a three monitor setup going left to right, all horizontal. The dock either wants to be on the left side of the left monitor or the right side of the right monitor. I can not get it positioned on the center monitor. It would be great if it were more "aware" of the connected monitors. I believe it has something to do with Xinerama and X11 treating all monitors as one big display. I bet if I oriented my monitors with two monitors in the center (one above and below) and the third to the right of the first two, I could at least get the dock on the left side of my center screen. Would love to see this be a bit more flexible. Thanks.

kugelblitz commented 1 year ago

@tstraus13 I think your request will be fulfilled as well if there is an option to keep the dock on the primary screen. You would probably want to make your center monitor primary (in XRandR's sense), and WindowMaker would detect where the primary monitor is (via XRRGetMonitors), and position the dock there.

So this probably does not need to be a big change, no universal flexibility, nothing like that. Just one checkbox.

tstraus13 commented 1 year ago

Yes I think your are right if we could “pin” the dock to the primary monitor that would probably work. I would also say though that you should be able to drag the dock to any monitor but the ability to use the primary monitor would be the answer for most people. I noticed that when minimizing windows that they seem to be monitor aware in the sense that if on my right monitor it minimizes to that screen instead of the left monitor.

d-torrance commented 1 year ago

I've just submitted some patches that implement this to the mailing list. See https://groups.google.com/g/wmaker-dev/c/LiB5sS3z8eo/m/rZUUTenhCQAJ.

tstraus13 commented 1 year ago

Wow. Awesome. Thanks a lot! It’s a much appreciated feature.

d-torrance commented 1 year ago

This feature is now available on the next branch. Let us know if there are any bugs!

tstraus13 commented 1 year ago

Thanks again! Apologies for my lack of knowledge but is there any documentation for building/running the next branch? Or is it as simple as

make

and

make install

Any dependencies?

d-torrance commented 1 year ago

http://www.windowmaker.org/docs/installation.html gives the basics, but it's assuming you're building from a tarball. So start off with:

git clone https://repo.or.cz/wmaker-crm.git -b next
cd wmaker-crm
./autogen.sh

After that, it's the same.

tstraus13 commented 1 year ago

I was just on the site. Must have missed that page somehow. Thanks.

d-torrance commented 1 year ago

I realized there's still a bit more to do. While moving the dock will keep it on the primary screen now, it doesn't start up on the primary screen. I'll work on it some more.

kugelblitz commented 1 year ago

Thank you! I will wait and then test on my system when you are finished.

d-torrance commented 1 year ago

I think I've addressed the missing things -- the latest patches are now on the next branch.

d-torrance commented 1 year ago

I'm discovering a few quirky bugs with this feature -- I'll list them here as I find them.