search

window-maker / wmaker

Mirror of the official repository repo.or.cz/wmaker-crm.git. Do not send pull requests here, send your patches to wmaker-dev@googlegroups.com instead
https://repo.or.cz/wmaker-crm.git
GNU General Public License v2.0
124 stars 18 forks source link

comments in appearance.menu not allowed #28

Open d-torrance opened 1 year ago

d-torrance commented 1 year ago

The following bug was just reported in Debian (see https://bugs.debian.org/1034638):

From: Helge Kreutzmann <debian@helgefjell.de>
Subject: Bug#1034638: wmaker: comments in appearance.menu not allowed
To: Debian Bug Tracking System <submit@bugs.debian.org>
Date: Thu, 20 Apr 2023 11:31:51 -0400 (4 hours, 55 minutes, 33 seconds ago)
Reply-To: Helge Kreutzmann <debian@helgefjell.de>, 1034638@bugs.debian.org
Resent-From: Helge Kreutzmann <debian@helgefjell.de>
Flags: seen, signed, list
Maildir: /Piedmont/INBOX
List: wmaker.tracker.debian.org

[[PGP Signed Part:Undecided]]
Package: wmaker
Version: 0.95.9-3+b2
Severity: minor

Yesterday I got the following error messaage:
2023-04-19T20:00:02.520024+02:00 twentytwo
/usr/libexec/WindowMaker/wmaker[2864]: (getPropList(proplist.c:885)):
warnung: Syntaxfehler in file /usr/share/WindowMaker/appearance.menu,
Zeile 1: Zeichenkette, Binärdaten, Array oder Dictionary
erwartet. Zeichenketten ggf. mit " einklammern.
2023-04-19T20:00:02.521878+02:00 twentytwo /usr/libexec/WindowMaker/wmaker[2864]: (getPropList(proplist.c:888)): warnung: Kommentare sind in Domänendaten von WindowMaker nicht erlaubt.

In english:
Warning: Syntaxerror in  file /usr/share/WindowMaker/appearance.menu line 1: String, binary data, array or dictionary expected. Escape strings possibly by "
Warning: Comments are not allowed within domain names from window maker.

# head /usr/share/WindowMaker/appearance.menu
#include "wmmacros"

Appearance MENU
  "Background" OPEN_MENU background.menu
  …

-- System Information:
Debian Release: 12.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to de_DE.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages wmaker depends on:
ii  libc6           2.36-9
ii  libexif12       0.6.24-1+b1
ii  libfontconfig1  2.14.1-4
ii  libwings3       0.95.9-3+b2
ii  libwraster6     0.95.9-3+b2
ii  libwutil5       0.95.9-3+b2
ii  libx11-6        2:1.8.4-2
ii  libxext6        2:1.3.4-1+b1
ii  libxinerama1    2:1.1.4-3
ii  libxpm4         1:3.5.12-1.1
ii  wmaker-common   0.95.9-3

wmaker recommends no packages.

Versions of packages wmaker suggests:
ii  desktop-base                   12.0.5
ii  konsole [x-terminal-emulator]  4:22.12.3-1
pn  wmaker-data                    <none>
pn  wmaker-utils                   <none>
ii  x11-apps                       7.7+9
ii  xterm [x-terminal-emulator]    379-1

-- no debconf information

-- 
      Dr. Helge Kreutzmann                     debian@helgefjell.de
           Dipl.-Phys.                   http://www.helgefjell.de/debian.php
        64bit GNU powered                     gpg signed mail preferred
           Help keep free software "libre": http://www.ffii.de/

[[End of PGP Signed Part]]
dmaciejak commented 1 year ago

That issue does not happen on vanilla wmaker. It's introduced by the debian specific root menu from plmenu.Debian file which is stored as /usr/share/WindowMaker/menu.hook from line 19: (Appearance, OPEN_MENU, appearance.menu)