search

window-maker / wmaker

Mirror of the official repository repo.or.cz/wmaker-crm.git. Do not send pull requests here, send your patches to wmaker-dev@googlegroups.com instead
https://repo.or.cz/wmaker-crm.git
GNU General Public License v2.0
124 stars 18 forks source link

texi2txt: Use ChangeLog date instead of build date #35

Closed jubalh closed 10 months ago

jubalh commented 10 months ago

in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good.

This date call works with GNU date and BSD date.

Without this patch, /usr/share/doc/packages/WindowMaker/README.i18n will differ in the line Published by The Window Maker team on ...

An alternative solution could use the $SOURCE_DATE_EPOCH variable defined in https://reproducible-builds.org/specs/source-date-epoch/

jubalh commented 10 months ago

Upstreaming this patch which we use in our openSUSE package. Author: @bmwiedemann

d-torrance commented 10 months ago

Please submit patches to wmaker-dev@googlegroups.com. Thanks!

jubalh commented 10 months ago

AFAIK GitHub has a setting where you disable pull requests for your repo. It might be good to disable them to not confuse people. Or mention the fact that PRs won't be accepted in the README (did I overlook it?).

I'll see when I get around to sending it via mail.

d-torrance commented 10 months ago

AFAIK GitHub has a setting where you disable pull requests for your repo. It might be good to disable them to not confuse people.

There doesn't appear to be, or we would have done this. See, for example, https://github.com/dear-github/dear-github/issues/84

Or mention the fact that PRs won't be accepted in the README (did I overlook it?).

It's in the repository description.

I'll see when I get around to sending it via mail.

Thanks!

jubalh commented 10 months ago

It's in the repository description.

Indeed I missed that!