search

windoze / tvision

Clone of Turbo Vision library at http://sourceforge.net/projects/tvision, by SET<set@users.sourceforge.net>
GNU General Public License v2.0
8 stars 2 forks source link

release.c For TVOSf_NT, change the yield from -1 (forever) to 100. #3

Closed guy-rouillier closed 4 years ago

guy-rouillier commented 6 years ago

For TVOSf_NT, change the yield from -1 (forever) to 100. This fixes several issues under Windows 7 64-bit compiled with mingw-w64 in the tvedit sample with file tvedit.cc: the WinGr driver would hang at initialization; the WinNT and Win32 drivers would scroll the cursor down, but would stop scrolling up at the first function; copy and paste would cause the displayed source to jump all around.

0001-For-TVOSf_NT-change-the-yield-from-1-forever-to-100..patch.txt

windoze commented 6 years ago

Thanks! Sorry I didn't test under Windows64/MinGW-w64, would you like to submit PRs for these issues?

Regards.

guy-rouillier commented 6 years ago

Yes, I can do that. We will have to review my changes for compatibility with other compiler and OS combinations; I simply made changes as necessary to get the package to build on Win64 using mingw-w64 in 64-bit. As I noted in one of the tickets, I know at least one of my changes won't work on 32-bit: in regex.c, where I changed the the cast for register assignment from unsigned to unsigned long long.

Ugh, did some Googling on this topic, here is a discouraging discussion:

https://stackoverflow.com/questions/36952464/size-of-cpu-register

We'll have to think about this. I just tried switching to void* and that didn't work, since mingw-w64 thinks high_reg and low_reg are int.

Thanks.

-- Guy Rouillier

------ Original Message ------ From: "徐辰" notifications@github.com To: "windoze/tvision" tvision@noreply.github.com Cc: "guy-rouillier" guy.rouillier@gmail.com; "Author" author@noreply.github.com Sent: 3/23/2018 3:45:29 AM Subject: Re: [windoze/tvision] release.c For TVOSf_NT, change the yield from -1 (forever) to 100. (#3)

Thanks! Sorry I didn't test under Windows64/MinGW-w64, would you like to submit PRs for these issues?

Regards.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/windoze/tvision/issues/3#issuecomment-375569931, or mute the thread https://github.com/notifications/unsubscribe-auth/ADacPbhfUtD4e3kQsHX2Bt9rjuiomw78ks5thKgZgaJpZM4S4Q5K.

guy-rouillier commented 6 years ago

This is my first time submitting a pull request to the windoze/tvision repository. How should I do that? Create a fork of the project and create a pull request from the fork? Or do you want to give me push access to your repo, and I can create a feature branch there?

Thanks.

-- Guy Rouillier

------ Original Message ------ From: "Guy Rouillier" guy.rouillier@gmail.com To: "windoze/tvision" reply@reply.github.com Sent: 3/23/2018 9:25:19 PM Subject: Re[2]: [windoze/tvision] release.c For TVOSf_NT, change the yield from -1 (forever) to 100. (#3)

Yes, I can do that. We will have to review my changes for compatibility with other compiler and OS combinations; I simply made changes as necessary to get the package to build on Win64 using mingw-w64 in 64-bit. As I noted in one of the tickets, I know at least one of my changes won't work on 32-bit: in regex.c, where I changed the the cast for register assignment from unsigned to unsigned long long.

Ugh, did some Googling on this topic, here is a discouraging discussion:

https://stackoverflow.com/questions/36952464/size-of-cpu-register

We'll have to think about this. I just tried switching to void* and that didn't work, since mingw-w64 thinks high_reg and low_reg are int.

Thanks.

-- Guy Rouillier

------ Original Message ------ From: "徐辰" notifications@github.com To: "windoze/tvision" tvision@noreply.github.com Cc: "guy-rouillier" guy.rouillier@gmail.com; "Author" author@noreply.github.com Sent: 3/23/2018 3:45:29 AM Subject: Re: [windoze/tvision] release.c For TVOSf_NT, change the yield from -1 (forever) to 100. (#3)

Thanks! Sorry I didn't test under Windows64/MinGW-w64, would you like to submit PRs for these issues?

Regards.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/windoze/tvision/issues/3#issuecomment-375569931, or mute the thread https://github.com/notifications/unsubscribe-auth/ADacPbhfUtD4e3kQsHX2Bt9rjuiomw78ks5thKgZgaJpZM4S4Q5K.

guy-rouillier commented 5 years ago

Submitted one quite awhile ago, did you ever receive it? Thanks.

-- Guy Rouillier

On 3/23/2018 3:45:29 AM, "徐辰" notifications@github.com wrote:

Thanks! Sorry I didn't test under Windows64/MinGW-w64, would you like to submit PRs for these issues?

Regards.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/windoze/tvision/issues/3#issuecomment-375569931, or mute the thread https://github.com/notifications/unsubscribe-auth/ADacPbhfUtD4e3kQsHX2Bt9rjuiomw78ks5thKgZgaJpZM4S4Q5K.

set-soft commented 4 years ago

I adapted the patch using uipointer and ipointer, the definitions of the "Compat Layer" code in Turbo Vision to cast pointers. This should work for all supported targets.

windoze commented 4 years ago

Sorry for the tooooooooooo late response, don't know why but I never received notification, maybe my email server was doing some nasty things...

windoze commented 4 years ago

The PR was merged. Thank you very much.