search

windranger-io / windranger-governance

BitDAO Governance contracts framework
Apache License 2.0
20 stars 10 forks source link

[Feature] Slither #101

Closed bitparadigm closed 2 years ago

bitparadigm commented 2 years ago

Purpose for this PR

Add Slither to the CI pipeline and make adjustments accordingly. Analysis excludes dependencies, unavoidable low level calls with arbitrary eth send, unused-return, shadowing of gap and low impact issues.

CjHare commented 2 years ago

I'm not entirely sure why the Slither is not working for this repo when the GitHub workflow code is the same setup as windranger-treasury (which build successfully today).

The error is the logs being the artefacts are not created (these are analyzed by Slither), suggesting the npx hardhat --force was not run, unsure on why that would be.

My suggestion is to change the GH workflow to match that from the windranger-solidity-template Silther PR as that removed the dependency on the external plugin, instead uses only the core GH Actions.