search

windranger-io / windranger-governance

BitDAO Governance contracts framework
Apache License 2.0
20 stars 10 forks source link

[Testing] Enable ci automated testing #65

Closed bitparadigm closed 3 years ago

bitparadigm commented 3 years ago

Closes https://github.com/windranger-io/windranger-governance/issues/55.

CjHare commented 3 years ago

question: why are both the push and pull_request being run by this pull request.

Expected behaviour would be only the pull_request runs with a pull request, push being run on main when the PR is merged across. e.g. Checks run in this PR https://github.com/windranger-io/windranger-treasury/pull/69

bitparadigm commented 3 years ago

I was able to run Slither locally. It indeed shows some 2 red suggestions and 3 yellow suggestions, which needs to be updated, but it's a whole separate PR and more than 10 green suggestions.

bitparadigm commented 3 years ago

Interesting that it shows red error in OZ code, so I might not be able to do anything about it.


    Dangerous calls:
    - (success) = target.call{value: value}(data) (node_modules/@openzeppelin/contracts/governance/TimelockController.sol#331)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#functions-that-send-ether-to-arbitrary-destinations```
CjHare commented 3 years ago

whole separate PR

Sounds good 👍

error in OZ code

When running Slither it'll be worthwhile excluding certain paths (such as OZ) with the --filter-paths option e.g.

slither . --filter-paths "BitDAO.sol|node_modules"