search

windranger-io / windranger-treasury

Apache License 2.0
16 stars 7 forks source link

[Feature] Consider calling _setDaoMetadata() in createDao() #359

Open aodhgan opened 2 years ago

aodhgan commented 2 years ago

Feature Description

Suggested by @octavioamu to save gas

Additional Information

CjHare commented 2 years ago

suggestion: need more context.

What is currently being done? How does this change save gas?

octavioamu commented 2 years ago

Basically the suggestion is to do it the same way is done in Bonds. As this was a missed part of the implementation, the method to setDaoMetadata was added but is not part of the createDAO for example to be able to createDAO(address, Metadata) paying gas once instead of CreateDao(address) (wait to finish) setDaoMetadata(metadata). Paying gas twice

CjHare commented 2 years ago

Gotcha, it to align it with Bonds 👍