windranger-io / windranger-treasury

Apache License 2.0
16 stars 7 forks source link

[Bug] StakingPoolFactory missing params #365

Closed aodhgan closed 2 years ago

aodhgan commented 2 years ago

Bug Description

consider emitting both maxTotalPoolStake and minTotalPoolStake from StakingPoolCreated event

Steps to Reproduce

1. 2. 3. 4.

Current Behaviour

Expected Behaviour

Additional Information

octavioamu commented 2 years ago

thanks @aodhgan , just for context, this is a very important piece for the UI, needed to build the displayed data, like the progress bar and states.

CjHare commented 2 years ago

@octavioamu so you are saying, this is less of 'consider implementing' rather it's 'essential to implement' 😉

octavioamu commented 2 years ago

yep it is essential to implement I cannot build the UI without it. all those bar need to know the totals to render https://bonds-5nzdu6djp-windranger.vercel.app/pools?dao=bitdao