windrobin / timemap

Automatically exported from code.google.com/p/timemap
MIT License
0 stars 0 forks source link

prototype.js breaks timemap #21

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Reproduction:
1. Include prototype.js (from http://prototypejs.org) in any page using
TimeMap.
2. Fire it up.

Output:
Error: iterator.bind is not a function, in prototype.js

The problem is line 212 in timemap.js.  It uses the for (x in
some_iterable) method of iterating over functions in filters.chain. 
Unfortunately, since prototype works by extending base objects like, say,
Object itself), there are some extra keyed items in the array Object, like
the each method, so in addition to calling the filter methods added by
TimeMap, prototypes each function also gets called and bonks.

I've attached a very simple patch that seems to fix the problem.

Original issue reported on code.google.com by kenichi....@gmail.com on 11 Jul 2008 at 3:29

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in trunk.

Original comment by nick.rab...@gmail.com on 18 Aug 2008 at 4:16