search

windwp / nvim-ts-autotag

Use treesitter to auto close and auto rename html tag
MIT License
1.54k stars 85 forks source link

feat: remove dependency on `nvim-treesitter`. Needed for `nvim-treesitter` rewrite. Requires Neovim >= 0.9.4 #171

Closed folke closed 2 months ago

folke commented 2 months ago

This PR removes the dependency on nvim-treesitter and uses Neovim's treesitter methods.

Without this PR, nvim-ts-autotag will be broken once the nvim-treesitter rewrite is released.

Some tests related to eruby seems to fail, but I'm not sure this is due to these code changes.

PriceHiller commented 2 months ago

Hi @folke, I've begun maintaining a fork over @ https://github.com/PriceHiller/nvim-ts-autotag/ that should be compatible with the latest breaking changes upstream until windwp hopefully comes back. It seems they've been inactive over here for a few months.

There's been a few minor configuration changes to how setup is done, but nothing major.

You may want to give it a shot until windwp is back 🙂.

folke commented 2 months ago

oh nice. Maybe you should also open a pull request in this repo for more visibility? Then I can close this one

PriceHiller commented 2 months ago

oh nice. Maybe you should also open a pull request in this repo for more visibility?

It's more than just nvim-treesitter, it's quite a bit wrapped up in it including other PRs that sat in limbo.

I guess I should open it anyways for tracking.

Will do here shortly.

PriceHiller commented 2 months ago

Will do here shortly.

Done.

folke commented 2 months ago

Closing in favor of #173

Will start testing your fork! :)

windwp commented 2 months ago

@folke I like your PR. Thank

folke commented 2 months ago

oh awesome, thanks!! :)