search

windwp / nvim-ts-autotag

Use treesitter to auto close and auto rename html tag
MIT License
1.63k stars 87 forks source link

Add astro filetype to internal #89

Closed simonward87 closed 1 year ago

simonward87 commented 1 year ago

Closes #84

I'm new to working with treesitter, but this made sense when looking through Treesitter playground, and it seems to work as expected.

bushblade commented 1 year ago

I can confirm that this solves #84 for me.

callumw-k commented 1 year ago

Awesome, can confirm this is working for me as well.

doganalper commented 1 year ago

This works but why is it not reviewed yet? @windwp are you still working on this plugin?

windwp commented 1 year ago

sorry can you rebase

simonward87 commented 1 year ago

Done. Let me know if there's any issues

bushblade commented 1 year ago

This may be unrelated but I'm curious if any of you also experience this issue if you're also using nvim-cmp https://github.com/hrsh7th/nvim-cmp/issues/1471

simonward87 commented 1 year ago

This may be unrelated but I'm curious if any of you also experience this issue if you're also using nvim-cmp hrsh7th/nvim-cmp#1471

It's probably an autopairs issue rather than autotag. I only skimmed the issue but If it's the problem I think it is, i've already got a fix for it — just haven't made a pull request yet, as I was waiting on this to be merged. I'll do it this week if I have time.

doganalper commented 1 year ago

This may be unrelated but I'm curious if any of you also experience this issue if you're also using nvim-cmp hrsh7th/nvim-cmp#1471

It's probably an autopairs issue rather than autotag. I only skimmed the issue but If it's the problem I think it is, i've already got a fix for it — just haven't made a pull request yet, as I was waiting on this to be merged. I'll do it this week if I have time.

Great, I was experiencing same issue but didn't get what caused the problem. Waiting for your fix.

bushblade commented 1 year ago

Interesting, I'll keep an eye out for that. @simonward87 I tried your fork of auto-pairs but have almost the same issue in astro files. I still get the completion suggestion from cmp but if I close that and hit enter, it does behave correctly.