search

windwp / vscode-expand-region

porting sublime-expand-region to visual code
GNU General Public License v3.0
57 stars 23 forks source link

Overrides ⌘-w not ⌃-w #2

Closed yankeeinlondon closed 7 years ago

yankeeinlondon commented 7 years ago

On the mac this overrides ⌘-w which is a big no-no. I think this should have been CTRL-w as the documentation states.

windwp commented 7 years ago

you can change it by set keyboard shortcut

"key": "ctrl+w","command": "expand_region"

yankeeinlondon commented 7 years ago

Well actually the problem is worse than this. Setting it to a new value of whatever you want is easy enough. The problem is that the default behaviour of the addon is to clobber one of the most common keyboard shortcuts that people use. To recover people must manually override the override:

"key": "cmd+w","command": "workbench.action.closeActiveEditor"

this works but is rather unsatisfying since now my "default keyboard shortcuts" define ⌘w twice and I come in at the end and set it a third time.

windwp commented 7 years ago

I just disable default keybinding. You can upgrade extension right now.

yankeeinlondon commented 7 years ago

ok thanks