Closed Caleb-Cohen closed 1 year ago
Looks good to me. 👍🏼
One last thing, can we move the users list to a new page
/directory
?
Do you want anything other than the users list on the directory page? Like Dev-Directory
or log in stuff?
for now, we can say no, but we should have a header on every page at some point. def a different task though!
for now, we can say no, but we should have a header on every page at some point. def a different task though!
So like a header component?
@timmyichen ready for approval/feedback
Where did we land on putting this in a new page? We know for sure it'll be a different page, what that page is named is up in the air (I'm fine with anything), but we should move everything out of the index file since doing so will allow to actually iterate on the homepage. Otherwise we'll keep piling features on the homepage, making the separation in the future more hairy.
Where did we land on putting this in a new page? We know for sure it'll be a different page, what that page is named is up in the air (I'm fine with anything), but we should move everything out of the index file since doing so will allow to actually iterate on the homepage. Otherwise we'll keep piling features on the homepage, making the separation in the future more hairy.
Not sure I'm following the question. I moved all the related user information to the directory folder and modeled the structure similar to onboarding.
Closes #59
Description
Please include a summary of the changes. Please also include relevant motivation and context. List any dependencies that are required for this change.
Added visualizing users onto the homepage. Only the discord name is visualized per the issue request.
Testing
Describe what a reviewer should do to test your code, including instructions for manually testing as well as relevant automated test suites to run.
execute
npm run cypress:open
and navigate the GUI to start the test.Type of change
Please remove all except for everything applicable, and then remove this line.
Screenshots
Checklist: