search

windytan / redsea

Command-line FM-RDS decoder with JSON output.
MIT License
390 stars 36 forks source link

wrong unicode symbol in the getLCDchar method #34

Closed flux242 closed 7 years ago

flux242 commented 7 years ago

"Sie hoeren: KUNGS FEAT. JAMIE N - DON‖T YOU KNOW"

"¤" - this one seems to be also wrong. I haven't checked any further

windytan commented 7 years ago

Thanks. Which station is this? Do you happen to have any hex data? I'm seeing correctly decoded apostrophes from at least ANTENNE and RADIO 21.

flux242 commented 7 years ago

the table in the getLCDchar does contain wrong symbols. The symbol before 'a' should be ` but in the table it is ‖

the 5th symbol in the table is ¤ but should be $

shouldn't they?

windytan commented 7 years ago

The character table is the default charset from page 74 of the 1998 RDS specification. I think this could be fixed by supporting repertoire control codes (switching character sets).

windytan commented 7 years ago

Or perhaps these characters could just be changed...

flux242 commented 7 years ago

well, seems like radio stations are just using the ascii symbols codes and not the ones defined in the standard.

windytan commented 7 years ago

idea: A config file with per-station workaround preferences (like "ascii_strings": true)

flux242 commented 7 years ago

Maybe you don't need to improve the outdated EBU tables standard at all? Just wanted to add that the symbols could be substituted by the postprocessing. I think I could do such substitutions even using jq -> split("‖") | join("`") for the specific station pi. Sorry for the 'spam' issue

windytan commented 7 years ago

Not spam at all, very useful discussion :) It seems the standard is applied quite liberally in different parts of the world and by different encoders.