search

windytan / slowrx

A decoder for Slow-Scanning Television (SSTV).
ISC License
98 stars 11 forks source link

Fixes the processing of images encoding using PD* modes #11

Closed C15 closed 2 years ago

C15 commented 2 years ago

Hi,

I know slowrx hasn't been maintained for a long time, but I really like its detection capabilities. It works really well for me with the exception of being able to properly decode images encoded using any of the PD* modes, as reported in issue #6.

The following changes to the source should solve issue #6 without creating any others. I tried to follow the existing structure of the program, without introducing changes to the processing of any modes other than PD modes.

Below is a comparison showing the decoding of a PD120 image transmitted by the ISS during the current DEC 2021 ARISS event without these changes, to the left, and with these changes, to the right.

slowrx_before_after

I have also tried decoding images encoded with other PD modes and other non PD modes, using Youtube videos as sources, and they we're all successfully decoded. All features such as autostart, autosave, fskid, etc, continued to work as expected.

windytan commented 2 years ago

Wow, awesome work! Never thought slowrx would get a fix like this.

windytan commented 2 years ago

I don't have any practices for this repo, but I tested that it compiles & runs and merged as is. Thanks!