search

winepak / applications

A collection of flatpak manifest for building Microsoft Windows applications with Wine via flatpak
https://www.winepak.org
416 stars 39 forks source link

Adding StarCraft to WinePak #121

Open Isakku opened 5 years ago

Isakku commented 5 years ago

Changed icon and scripts, testing is required. Followed @Saroufim instructions here https://github.com/winepak/applications/issues/116#issuecomment-412320014 I'm no expert with Wine or Flatpak, this is my first pull request here.

Isakku commented 5 years ago

Add the correct icon https://us.shop.battle.net/static/3.2.1/images/family-icons/starcraft-remastered.svg

Lol, and that's the icon we are supposed to use? I really liked the Terran Wraith that SC1 had and I loved that new Wraith redesign they supplied with 1.16, but now they give us this bland SC letters... sigh OK, I'm doing it.

EDIT Hmm. while we are at it, could you please tell me how do you test this? I mean, how do you test winepak scripts that are offline and were made by yourself with mostly possible horrific bugs without breaking your system (I already found a bug with SC2 winepak) https://github.com/winepak/applications/issues/122 When I was editing it to make the SC1 script I noticed that it changes Wine graphics mode to opengl... I don't know why. Lutris SC2 install script does many other different things but nothing like that.

Isakku commented 5 years ago

There is really no way I can make this work if the code It is based on (StarCraft II Winepak) fails on my side (issue #122)