Add org.freedesktop.Platform.GL32 extension

winepak / winepak-sdk

Platform and SDK runtimes for winepak based applications

50 stars 18 forks source link

Add org.freedesktop.Platform.GL32 extension #15

Closed jjedelsky closed 6 years ago

jjedelsky commented 6 years ago

Add org.freedesktop.Platform.GL32 extension for 32bit nvidia libGL support on 64bit environment. Based on flathub's Steam flatpak Issue #14 This should fix https://github.com/winepak/applications/issues/37

Iolaum commented 6 years ago

Could this potentially also affect this problem ?

jjedelsky commented 6 years ago

It seems likely to me. WoW64 needs 32bit libGL. Nvidia libGLs are provided by org.freedesktop.Platform.GL.nvidia-[version] and org.freedesktop.Platform.GL32.nvidia-[version], but org.winepak.Platform does not have mountpoint for org.freedesktop.Platform.GL32, so 32bit nvidia libGLs are not exposed even if they are installed.

Iolaum commented 6 years ago

Thanks for the reply, while on the subject I 've another question:

I see you added GL32 at the add-extensionssection but GL is added is added at the inherit-extensions. Is there a reason you chose to do it differently? Don't know that much about flatpaks, while checking the docs I couldn't understand the difference, and therefore the ddifferent benefits, between:

inherit-extensions (array of strings): Inherit these extra extensions points from the base application or sdk when finishing the build.
base-extensions (array of strings): Install these extra extensions from the base application when initializing the application directory.
add-extensions (objects): This is a dictionary of extension objects. The key is the name of the extension. See below for details.

jjedelsky commented 6 years ago

GL extension is added in org.freedesktop.Sdk, which is base sdk for org.winepak.Sdk, so it could be inherited. GL32 and Compat32 are not, because they are usually included by application, not by sdk/platform. Winepak sdk/platform includes wine, which needs 32bit libraries, so it includes Compat32 by itself and I think it would make sense to include GL32 as well.

inherit-extensions: the simplest way to include extension already added by base sdk/app
base-extensions: same as inherit-extensions, but extensions included this way may be used at build time
add-extensions: define mountpoint (and other stuff) by yourself

julianrichen commented 6 years ago

Sorry about the delay, I was on vacation and got back a few days ago.

Thank you for looking into this. Hopefully this fixes Nvidia user's issues!

This has also been added in the redesign branch: 6f2b5ded75d05a90a269927fbfff22160be333ed

julianrichen commented 6 years ago

I pushed the change to current Platform and it should be live in the repo, just update and see if things improve.

flatpak -y update org.winepak.Platform//3.0

brlbil commented 6 years ago

I have tried with StarCraft 2, the update did not install org.freedesktop.Platform.GL32 automatically, I do not know that it should do but after installing org.freedesktop.Platform.GL32 I could install and play StarCraft 2 with a Nvidia card.