Bump dxvk and split it into multiple extensions based on versions number

winepak / winepak-sdk

Platform and SDK runtimes for winepak based applications

50 stars 18 forks source link

Bump dxvk and split it into multiple extensions based on versions number #18

Closed Lctrs closed 5 years ago

Lctrs commented 6 years ago

Depends on #17.

julianrichen commented 6 years ago

Hello,

The branch name will actually need to be 3.0 or the Sdk & Platform won't pick it up because it's version is searching for 3.0.

I'm wondering if we should ship each version as

org.winepak.Platform.Extension.dxvk-59
org.winepak.Platform.Extension.dxvk-60
org.winepak.Platform.Extension.dxvk-61

Like the flatpak teams does Nvidia drivers. Does dxvk regress enough that's it's an issue that we need each version or can we just ship it as org.winepak.Platform.Extension.dxvk with always the latest version?

Lctrs commented 6 years ago

DXVK bump regularly the minimum required wine version. So we might need a different branch for each version in case a game is not compatible with the new wine version.

julianrichen commented 6 years ago

Alright, let's change the version-ing to *.Extension.dxvk-XX so things don't break. That's kind of the point of winepak anyway.

Changes:

org.winepak.Platform.Extension.dxvk.yml -> org.winepak.Platform.Extension.dxvk-060.yml
branch number from 0.60 -> 3.0
for each source's dest-filename in the scripts module let's rename dxvk-install to dxvk-install64 and dxvk-install32 for 64 bit and 32 bit respectively so it matches the other modules.

You can edit this pr or start a new one, which every is easier for you.

Lctrs commented 6 years ago

@julianrichen done.

julianrichen commented 6 years ago

I tested the code, it's not currently installing because we need to use the setup_dxvk.sh script. I really shouldn't have merged the original pr in a hurry before I left for vacation. At least I didn't push it to the repo...

Lctrs commented 6 years ago

@julianrichen I think I finally managed to have a working install.

Lctrs commented 6 years ago

@julianrichen since dxvk seems to follow semver, we could be on the safe side by doing an extension per minor version (eg. dvxk-05x, dxvk-06x, etc.).

julianrichen commented 6 years ago

Cool, doing semver would also lower maintenance cost on our end. I'll hopefully be able to look into it more after the weekend and finally merge, builder, & push to the repo.

Lctrs commented 6 years ago

Will have time to do it on monday probably.

julianrichen commented 6 years ago

@Lctrs just tested all the changes and dxvk seems to install fine, great job! However, unable to test with a real game. See https://github.com/winepak/applications/pull/71#issuecomment-410751319

Lctrs commented 6 years ago

Hi @LeandroStanger.

I'm moving in a new apartment so I won't be able to do it until a few days.

julianrichen commented 6 years ago

I managed to play with this a bit today, tried to get WoW to use dxvk but had problems rendering :( Either way the scripts look good and the files install fine. Only issue I see is that 05x & 06x still have reference to the patch file that was used before the better 07x version was push. Can you remove those and I'll merge.

Still working on the Sdk redesign branch but this should work in both the new and current version so I can push it to the server now.