search

winfinit / aamvajs

AAMVA parser
BSD 3-Clause "New" or "Revised" License
35 stars 28 forks source link

Add version 06 #5

Closed mkazlauskas closed 7 years ago

mkazlauskas commented 7 years ago

Because class is a keyword and it wouldn't work in my environment. I need to have this so we got to branch it if you want to keep "class"

winfinit commented 7 years ago

in what environment "class" key is not accepted?

mkazlauskas commented 7 years ago

Dart. ES6 has class keyword as well so there may be potential issues with it too.

winfinit commented 7 years ago

don't know about dart, but there is no issue with ES6 having a key called class. I am not feeling "Klass" however if you are ok to change it to something like "dl_class" maybe, to fix a conflict that you are having, then I would be ok with that.

mkazlauskas commented 7 years ago

Alright, I think I found a compromise - keep both fields. Having klass alongside class won't hurt anyone, plus I have a feeling there may be other use cases where it's an issue (other transpilers?)