winfsp / hubfs

File system for GitHub & GitLab
https://winfsp.dev
GNU Affero General Public License v3.0
1.62k stars 60 forks source link

Consider changing license to GPL #11

Closed rpwoodbu closed 8 months ago

rpwoodbu commented 10 months ago

In this commit, WinFsp was changed from AGPL to GPL. I wonder if the same could be done for HUBFS. Many companies outright forbid the use of AGPL software in any capacity.

I think this is a very promising project, and I would like to contribute to it, but we cannot proceed with it under the AGPL.

billziss-gh commented 9 months ago

I would consider changing the license from AGPL to GPL.

Can you please let me know what kind of changes you would like to contribute?

rpwoodbu commented 9 months ago

Thanks for considering it!

I have observed stability issues with the cache expiration logic, and I would like to help address that. I would also like to make that more configurable, as it is too aggressive for my use-case. In particular, I don't leave files/directories open in-between builds, so the 30s expiration causes full cache loss between builds.

Another simple feature I'd like to add is a read-only option. We have a large monorepo, and what we want to do is use HubFS as a look-aside read-only view of the full repo, while doing development within an ordinary git worktree using sparse checkouts. We're using Bazel, and it has the ability (via --package_path) to look elsewhere for any files that are missing from the main workspace. I've shown that this works (e.g., I can build Envoy with only the root directory checked-out), but it is important for HUBFS to guarantee a pristine view of the repo.

I've only been able to experiment with HUBFS on my personal machine with public repos so far, as my company disallows any use of AGPL software, so I'm very glad to hear you'd consider changing the license.

rpwoodbu commented 8 months ago

Hi, Bill. We're anxious to begin trying out this code. When could you update the license?

billziss-gh commented 8 months ago

After thought I have decided to keep the license as AGPL and will offer a commercial license for the software in the future.