search

winfsp / sshfs-win

SSHFS For Windows
https://winfsp.dev
Other
4.78k stars 250 forks source link

Preventing timeouts with "ServerAliveInterval" #421

Closed Swift42 closed 3 months ago

Swift42 commented 3 months ago

As discussed in https://github.com/winfsp/sshfs-win/issues/420

billziss-gh commented 3 months ago

Thanks for the PR.

Is it a requirement to use UTF-16 for the ServerAliveInterval.reg file? Would it still work if we converted it to UTF-8? I am asking because the file is shown as "binary" in the GitHub diff (although it is shown correctly when viewed locally).

Swift42 commented 3 months ago

Is it a requirement to use UTF-16 for the ServerAliveInterval.reg file? Would it still work if we converted it to UTF-8? I am asking because the file is shown as "binary" in the GitHub diff (although it is shown correctly when viewed locally).

I don't know why it was imported as UTF-16 ... I edited it and this changed it to UTF-8, but it is still displayed as binary. Maybe because of the ".reg" extension?

Swift42 commented 3 months ago

Correction: Only the diff is displayed as binary, because the source file was binary. The final file should be normally readable now.

billziss-gh commented 3 months ago

I am merging this in. Thank you very much for your contribution!