Closed gfgit closed 6 months ago
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 50.00%. Comparing base (
d7cd173
) to head (17eb47b
).
Files | Patch % | Lines |
---|---|---|
como/win/tabbox/tabbox.h | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Code changes look good. 👍 There is one more commit message to change.
Code changes look good. 👍 There is one more commit message to change.
Which commit?
Code changes look good. 👍 There is one more commit message to change.
Which commit?
You can see that usually in the job output of the failing job.
In this case the commit input: fix: use new wayland enums
has body lines that are too long. Note that GitHub automatically folds too long lines. But if some dev later on tries to read the log on terminal it doesn't. To ensure readability of the git log, there is a max line length.
The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16
If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.
If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/
The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16
If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.
If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/
Thanks didn't know that! Though now it's a bit weird with first argument not indented and others indented because of preprocessor macros
Yea, so my philosophy with code style is: better have it sometimes weird but always consistent. 😄
Hi, this fixes some compile errors on KDE Neon Developer with GCC 11.4 Also fix enum names changes on wlroots 0.18.0