winft / como

The Compositor Modules provide means to create Wayland and X11 compositors
GNU General Public License v2.0
86 stars 5 forks source link

Add some missing includes #16

Closed gfgit closed 6 months ago

gfgit commented 6 months ago

Hi, this fixes some compile errors on KDE Neon Developer with GCC 11.4 Also fix enum names changes on wlroots 0.18.0

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.00%. Comparing base (d7cd173) to head (17eb47b).

Files Patch % Lines
como/win/tabbox/tabbox.h 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #16 +/- ## ========================================== - Coverage 50.02% 50.00% -0.02% ========================================== Files 938 938 Lines 87251 87251 Branches 45478 45496 +18 ========================================== - Hits 43647 43633 -14 - Misses 38674 38719 +45 + Partials 4930 4899 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

romangg commented 6 months ago

Code changes look good. 👍 There is one more commit message to change.

gfgit commented 6 months ago

Code changes look good. 👍 There is one more commit message to change.

Which commit?

romangg commented 6 months ago

Code changes look good. 👍 There is one more commit message to change.

Which commit?

You can see that usually in the job output of the failing job.

In this case the commit input: fix: use new wayland enums has body lines that are too long. Note that GitHub automatically folds too long lines. But if some dev later on tries to read the log on terminal it doesn't. To ensure readability of the git log, there is a max line length.

romangg commented 6 months ago

The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16

If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.

If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/

gfgit commented 6 months ago

The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16

If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.

If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/

Thanks didn't know that! Though now it's a bit weird with first argument not indented and others indented because of preprocessor macros

romangg commented 6 months ago

Yea, so my philosophy with code style is: better have it sometimes weird but always consistent. 😄