search

winft / wrapland

Qt/C++ library wrapping libwayland
GNU Lesser General Public License v2.1
9 stars 2 forks source link

Use reuse and SPDX identifier for automatic license compliance check #21

Open romangg opened 4 years ago

romangg commented 4 years ago

In GitLab by @ognarb on Apr 16, 2020, 09:49

Currently, KWinFT and Wrapland don't have any licensing compliance checks. I propose using reuse and a small ci job to check for compliance like I did here: https://invent.kde.org/websites/aether-sass/-/blob/master/.gitlab-ci.yml.

This is already done in KWayland. See https://phabricator.kde.org/D28058 and https://phabricator.kde.org/T11550.

romangg commented 4 years ago

Yes, SPDX is a Linux Foundation standard and reuse also seems to be managed well, so it's a good idea to make use of it.

Actually I looked into this when the patch for KWayland landed. One could use Andreas' script for that but I didn't yet find the time for it.

Since we just talked via PM about it and you said you wanna take a look at it I'm gonna assign you the task. Thank you Carl!

romangg commented 4 years ago

In GitLab by @ognarb on Apr 16, 2020, 23:59

I looked a bit more and it won't be possible to have a licensing compliance test.

Some files don't have a correct SPDX license: src/client/protocols/kwinft-output-management-unstable-v1.xml

so reuse lint will always give errors :(

romangg commented 4 years ago

All xml protocol files or only that one? What would need to change in that file?

romangg commented 4 years ago

The one from KWayland this is based on is this btw: https://cgit.kde.org/kwayland.git/tree/src/client/protocols/output-management.xml