search

winft / wrapland

Qt/C++ library wrapping libwayland
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Remove KDE decoration protocol #46

Closed romangg closed 5 months ago

romangg commented 4 years ago

The protocol: src/client/protocols/server-decoration.xml

It is replaced by xdg-decoration what is already supported by Wrapland.

So can we just remove the old one and not bother remodeling it? Or are there still some consumers?

romangg commented 4 years ago

Let's remove it for now and if afterwards we see that it shouldn't have been removed we can add it back.

@frmonteiro since you already have experience with removing QtSurfaceExtension maybe you want to solve the issue here too?

romangg commented 4 years ago

In GitLab by @frmonteiro on May 8, 2020, 19:44

I could try doing that.

romangg commented 4 years ago

In GitLab by @frmonteiro on May 8, 2020, 20:14

Should I also remove org_kde_kwin_server_decoration_palette_manager?

romangg commented 4 years ago

The palette class is for a different and independent protocol even though names are very similar. Look into client/protocol where you can find both xml.

Actually the palette one should be a very contained one and it's small. So if you want to give porting one class a shot again you can try the palette one after deleting the server decoration class. :)

romangg commented 4 years ago

mentioned in commit 7b4d69ba976e5e6fc037a196ebd5d42c46f0dc00

romangg commented 4 years ago

Closed by eb686af0e3e5bfc02a9584b4566c3ee9029badb0.

romangg commented 4 years ago

closed

romangg commented 4 years ago

mentioned in commit 9214ac1deaff61018f6a1588ca71eb858ebdcfdd