search

winft / wrapland

Qt/C++ library wrapping libwayland
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Remodel blur, contrast, slide classes #48

Closed romangg closed 5 months ago

romangg commented 4 years ago

These classes are pretty similar and should be all three well contained on their own.

Can likely be put together in a single merge request having three separate commits.

romangg commented 4 years ago

In GitLab by @frmonteiro on Apr 30, 2020, 14:32

Hi! I want to take over this task. I'm still new on C++, but I'm looking to the other remodels how to procede.

romangg commented 4 years ago

Hi Fernando. That's awesome!

You should be able to take one of the other classes as an example on how to remodel these three classes. But if you hit any road blocks or have any question for understanding just ask here directly.

Or in case the bulk of it goes smooth you can also directly create a (WIP) merge request and we can work out the rest there then.

romangg commented 4 years ago

In GitLab by @frmonteiro on Apr 30, 2020, 21:37

Hello Roman!

I'm having trouble accessing the slide_p class. How can I make it accesible to slide.cpp? I switched SlideManager::Private and Slide::Private from slide_interface.cpp to slide_p.h. I looked at the other classes on how to make it properly but couldn't find a way to make it accesible.

romangg commented 4 years ago

SlideManager::Private should be accessible by SlideManager directly since it's in SlideManager scope.

To access the declaration in the cpp file don't forget to include the slide_p.h header in this cpp file.

romangg commented 4 years ago

In GitLab by @frmonteiro on May 2, 2020, 02:50

Hello again!

Looks like I'm still doing something wrong about accessing the private class. For now I'm going to leave this for another person.

Don't worry I will still try to work on smaller bugs but before that I will study more C++ and will come back when I feel ready to do stuff here.

Sorry about that!

romangg commented 4 years ago

In GitLab by @frmonteiro on May 2, 2020, 02:50

unassigned @frmonteiro

romangg commented 4 years ago

No problem. Thanks for trying. Check out #52 for a small task. It's only about removing some deprecated code but it's still important and one can also learn a bit about the code structure by doing that.

romangg commented 4 years ago

Closed by ac634997e1aee1dcfb42ff6783d961f029cd82e4.

romangg commented 4 years ago

closed

romangg commented 4 years ago

mentioned in commit 9214ac1deaff61018f6a1588ca71eb858ebdcfdd