search

winft / wrapland

Qt/C++ library wrapping libwayland
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Remodel text-input #56

Closed romangg closed 8 months ago

romangg commented 4 years ago

This protocol is connected with Seat, but should be rather straight-forward to remodel. There are also the Pointer and Keyboard classes that can act as an example in regard to how they are connected with Seat.

romangg commented 4 years ago

In GitLab by @erreur404 on May 8, 2020, 13:20

hello, I want to try to refactor this class and I have one question about the implementation.

the current implementation has one global and multiple version herit from this one,

TextInputManager (Global) <----TextInputManagerV0

TextInputManager::Private <----TextInputManagerV0::Private

For TextInput, it's not a problem because we do not have any version in the constructor.

but now for global, we declare the version directly in heritage. what is the good thing to do to implement multiple versions?

romangg commented 4 years ago

I would say only use the V2 one. Replace the wrapper class with that for now. Then you have a simple TextInputManagerV2 : QObject and TextInputManagerV2::Private : Wayland::Global structure as in all the other remodeled classes.

romangg commented 4 years ago

Closed by 43a01b488ec25a75884dbf74ea5ca563c43e45cc.

romangg commented 4 years ago

closed

romangg commented 4 years ago

mentioned in commit 9214ac1deaff61018f6a1588ca71eb858ebdcfdd