wing3s / pysc2-rl-mini

StarCraft II Reinforcement Learning with Pytorch - Mini Games
Apache License 2.0
23 stars 3 forks source link

The factor of value loss #2

Open JIElite opened 6 years ago

JIElite commented 6 years ago

In worker.py, we need to sample experience by using local model and then backpropagate the gradients of total loss. The total loss is composed of loss_of_actor, loss_of_critic and entropy.

In line 132, you have already multiply 0.5 to value_loss_vb, but in line 152 you to that again. Does it mean the factor of critic loss in total loss is 0.25? Is it what you want to do?

Thank you. :)