search

wingedfox / dgeni-alive

Live docs on top of dgeni documentation generator
MIT License
26 stars 14 forks source link

removed .bowerrc from website processor template list #5

Closed andy-dorman closed 8 years ago

andy-dorman commented 8 years ago

So I'm locked into an old version of node at the moment and I've shimmed the various parts missing from pre-4 versions of node. The final obstacle was that the .bowerrc file was being copied out of the src/app/templates directory with the owner set to root which was causing permissions issues in the generateWebsite phase of the build.

I believe the underlying cause is related to this issue in some way:

https://github.com/npm/npm/issues/1862

and I can see that you've worked around it by handing the .bowerrc template entry to a dot.bowerrc template file. However, the file is simple setting the bower components directory to its default value so I'm assuming it can be removed, killing two birds with one stone?

Anyway, without this file I can generate my docs using node 0.10.25 and npm 1.3.24, which is currently necessary for the environment in which I'm working...

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 68.769% when pulling 29e213ee48d82cd5a50d154b775e376feef780a0 on pikselpalette:remove-bowerrc-template into b283c462323ed3060bdbfc64bde961d9e1d32540 on wingedfox:master.

andy-dorman commented 8 years ago

I'm not so sure that this is required now.

I found this which fixed my issue:

https://github.com/bower/bower/issues/2262

I'm going to close this pull request.