search

wingify / vwo-node-sdk

VWO Node SDK for server-side testing
https://developers.vwo.com/docs/fullstack-overview
Apache License 2.0
24 stars 9 forks source link

⚠️ You need to resolve these merge conflicts and redeploy immediately #54

Closed shanemac10 closed 11 months ago

shanemac10 commented 11 months ago

You have 2 merge conflicts that are being served to clients and breaking the functionality. Please resolve, rebuild, and redeploy ASAP! Thank you!

https://github.com/wingify/vwo-node-sdk/blob/c313f6fcfa7c51b0b326caf9bb6509c3fb46d73d/dist/vwo-javascript-sdk.min.js#L29

shanemac10 commented 11 months ago

https://cdn.jsdelivr.net/npm/vwo-node-sdk@1/dist/vwo-javascript-sdk.min.js

shanemac10 commented 11 months ago

Screenshot 2023-11-15 at 10 56 12 AM

shanemac10 commented 11 months ago

@rohitesh-wingify

shanemac10 commented 11 months ago

@softvar

rohitesh-wingify commented 11 months ago

Hey @shanemac10 . Yes. We are on it.

rohitesh-wingify commented 11 months ago

Hey @shanemac10, can you please check at your end, if this is resolved now?

shanemac10 commented 11 months ago

@rohitesh-wingify No, it's still the same file with the same issue. Nothing changed.

rohitesh-wingify commented 11 months ago

@shanemac10 Can you please check for the latest version? It is resolved it in the latest version.

https://cdn.jsdelivr.net/npm/vwo-node-sdk/dist/vwo-javascript-sdk.min.js

shanemac10 commented 11 months ago

@rohitesh-wingify No, the plugin is using this URL

https://cdn.jsdelivr.net/npm/vwo-node-sdk@1/dist/vwo-javascript-sdk.min.js

rohitesh-wingify commented 11 months ago

@shanemac10 Can you please upgrade the plugin to use the latest version? That has the issue resolved.

shanemac10 commented 11 months ago

@rohitesh-wingify No, it's not showing as having an update available.

rohitesh-wingify commented 11 months ago

@shanemac10 Can you please share your email ID so I can reach out to you?

shanemac10 commented 11 months ago

@rohitesh-wingify No thank you.

Let me clarify, my site had the latest plugin update as 4.1 from 2 days ago, and I'm not seeing a new one to be updated to.

Never mind, this below appears updated now... But either way, the issue appears to be with your .../dist/vwo-javascript-sdk* files having unresolved merge conflicts in them. These conflicts are still in the master repo, so perhaps start by resolving them and committing those to master.

softvar commented 11 months ago

Hi @shanemac10 ,

We have published a new version as the earlier one was faulty. The URL which you're using i.e. https://cdn.jsdelivr.net/npm/vwo-node-sdk@1/dist/vwo-javascript-sdk.min.js is reflecting the changes. Can you please try and confirm?

Also, I would like to highlight that if you're using vwo-node-sdk@1 in the URL, that means that whenever we will be pushing any new version (and after jsdelivr CDN, a third-party CDN, updates the cache) you will get the latest code which was published on GitHub and NPM. You can also provide the version manually if you're interested in updating the SDK only when you would like to do so like vwo-node-sdk@1.63.2.

Let us know if you have any further questions.

shanemac10 commented 11 months ago

@softvar Yes, I just tried it and the error had gone away. Thank you!

I'm not using anything other than your WordPress plugin and the account ID in the "Your VWO Account ID" field. I'm not sure why you guys keep telling me about the URLs that your plugin is pulling in, like I can do anything about it.

shanemac10 commented 11 months ago

Thanks for getting this knocked out so quickly