wingkwong / leetcode-the-hard-way

LeetCode The Hard Way - From Absolute Beginner to Quitter. Join Discord: https://discord.com/invite/Nqm4jJcyBf
https://linktr.ee/leetcodethehardway
883 stars 221 forks source link

Tutorial Writeup -Count Primes #177

Open Vidhanjain143 opened 2 years ago

yashgautam9274 commented 2 years ago

Interserd.

siddoinghisjob commented 2 years ago

@Vidhanjain143 are you working on it? if not then can I work on it @wingkwong ?

M-Rahul1 commented 2 years ago

I would like to add. Assign it to me @wingkwong .

siddoinghisjob commented 2 years ago

@wingkwong if no one is working on it, I would like to work on it. Kindly assign it to me.

M-Rahul1 commented 2 years ago

@wingkwong isn't it in sequential order while assigning?🤔

wingkwong commented 2 years ago

@M-Rahul1 Sorry. I read it wrong. I assigned based on the time and the number of tasks they have. You'll take it. Please read CONTRIBUTING.md and current PR comments to get the general idea first.

siddoinghisjob commented 2 years ago

@wingkwong Actually I asked you first for assigning me 😕

wingkwong commented 2 years ago

@siddoinghisjob Like I said before, it's based on the time AND the number of tasks on hand. Since you've Linear Search writeup on hand, so I assigned to @M-Rahul1 as he doesn't have any task currently. For writeups, I expect it may take much time for writing and reviewing, so I don't want people to hold multiple tasks on hand if there is other options.

M-Rahul1 commented 2 years ago

@wingkwong I have added a pull request. Kindly accept. This would be my 1st hacktoberfest PR😊

wingkwong commented 2 years ago

@M-Rahul1 Your PR https://github.com/wingkwong/leetcode-the-hard-way/pull/244 is rejected as you just copied and pasted from external site. Therefore, I'll unassign you from this issue.

M-Rahul1 commented 2 years ago

@wingkwong I'll give it a try again.

wingkwong commented 2 years ago

@M-Rahul1 Sorry. Plagiarism is not accepted and no chances will be given now. I hope you learn the lesson here.

M-Rahul1 commented 2 years ago

@M-Rahul1 Sorry. Plagiarism is not accepted and no chances will be given now. I hope you learn the lesson here. i just took reference, I thought the code would be same everywhere. Now i have changed it completely can you review it now. Anyways good refreshment of past topics. Thanks for this repo.

siddoinghisjob commented 2 years ago

@wingkwong I want to work on this. Can you please assign me

wingkwong commented 2 years ago

@siddoinghisjob You already one task on hand. I prefer someone who doesn't have any task to pick up.

siddoinghisjob commented 2 years ago

I have made the required changes in my other pr. If its alright then I am free now 😺. So you can assign me this one 👐

wingkwong commented 2 years ago

@siddoinghisjob please click re-request review next time. Otherwise I'd consider you're still modifying.

Akash-1gif commented 2 years ago

Hey @wingkwong I want to work on this issue. Please assign me the following task

emeraldnoob commented 2 years ago

Hey @wingkwong can I work on this issue? Please assign me the task

wingkwong commented 2 years ago

@emeraldnoob I believe @Akash-1gif is working on it. @Akash-1gif Lemme know if you are not.

Akash-1gif commented 2 years ago

Yes @wingkwong i'm working on it. I'll make my PR soon

Akash-1gif commented 2 years ago

Hey @wingkwong , I'm sorry for making a very late PR as my exams were scheduled. So I've made my PR. Please check it out and let me know if I can further make any changes

I've placed my .md file in the following filepath

leetcode-the-hard-way/tutorials/math/

wingkwong commented 2 years ago

Unassigned due to inactivity.

Abhinavrajsrivastav commented 1 year ago

I want to work on it, assign it to me.

wingkwong commented 6 months ago

Unassigned due to inactivity

South-IN commented 1 month ago

@wingkwong if no one is assigned to this issue can I work on it ?

wingkwong commented 1 month ago

@South-IN assigned. Please read CONTRIBUTING.md first.