wingkwong / leetcode-the-hard-way

LeetCode The Hard Way - From Absolute Beginner to Quitter. Join Discord: https://discord.com/invite/Nqm4jJcyBf
https://linktr.ee/leetcodethehardway
844 stars 214 forks source link

Added tutorial for shell sort #664

Closed Saishreekouda closed 9 months ago

Saishreekouda commented 9 months ago

Change Summary

Checklist

If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice. Regular contributors (with 10+ PRs) can skip this part.

General

Tutorial

Solutions

Saishreekouda commented 9 months ago

@wingkwong I made a few changes.

Saishreekouda commented 9 months ago

@wingkwong any more changes to be made?

Saishreekouda commented 9 months ago

@wingkwong are there any changes to be made?

Saishreekouda commented 9 months ago

I couldn't start the app. Please run it locally to verify first.

@wingkwong It's due to the images that I added on the github editor but that is giving error when i locally start it. I'm trying to fix this, I'd be glad if you could help.

wingkwong commented 9 months ago

I couldn't start the app. Please run it locally to verify first.

@wingkwong It's due to the images that I added on the github editor but that is giving error when i locally start it. I'm trying to fix this, I'd be glad if you could help.

Why would you use <img> tag? You can directly use the result generated by Github Editor, e.g.

![image](https://github.com/wingkwong/leetcode-the-hard-way/assets/35857179/b88821ec-96d8-436a-b91d-bf9508bc87bf)
Saishreekouda commented 9 months ago

@wingkwong fixed it.

Saishreekouda commented 9 months ago

@wingkwong any more changes?

Saishreekouda commented 9 months ago

@wingkwong any update?

wingkwong commented 9 months ago

@Saishreekouda will review tomorrow. next time please click re-request review. Sometimes I may miss it after getting flooded by notifications.