wingkwong / react-quiz-component

:orange_book: React Quiz Component
https://wingkwong.github.io/react-quiz-component/
MIT License
370 stars 142 forks source link

shuffle among answers feature added with valid correct answer #130

Closed Shariar-Hasan closed 11 months ago

Shariar-Hasan commented 11 months ago

if you merge this, can you please add hacktoberfest-accepted label while merging.

i have added the feature of

Shariar-Hasan commented 11 months ago
  1. Just FYI. This repository has been labelled as hacktoberfest so that all merged PRs will be counted without adding hacktoberfest-accepted. It's stated in the official website.
  2. Please run the lint (npm run lint) to avoid unrelated changes
  3. It should be more configurable. Let's have a new prop called shuffleAnswer so that users could shuffle on demand. See shuffle as a reference.
  4. Update README since there is a new prop.

got it, i am working on it

Shariar-Hasan commented 11 months ago

dear @wingkwong , first of all, sorry for asking many questions, as i am a newbie in PR related things,

i have created a PR, can you verify now. i tried to do what ever you asked for, only one thing is giving me error, which is this image

so the recent pull request is okay or i have to makje some other changes?

wingkwong commented 11 months ago

brohter, they didnt count my contribution. it says, the maintainer must add hacktoberfest-accepted label on pull request label 😓😓

It is stated clearly To be accepted, a maintainer either needs to MERGE your PR, .... and so far this PR is not ready to merge yet. You can't expect people just accept everything you made even it is not working. Hence, it is still not accepted YET. Once you fix that problem, I'll merge it and you will see it is accepted. Just be patient.

Shariar-Hasan commented 11 months ago

brohter, they didnt count my contribution. it says, the maintainer must add hacktoberfest-accepted label on pull request label 😓😓

It is stated clearly To be accepted, a maintainer either needs to MERGE your PR, .... and so far this PR is not ready to merge yet. You can't expect people just accept everything you made even it is not working. Hence, it is still not accepted YET. Once you fix that problem, I'll merge it and you will see it is accepted. Just be patient.

i am extremely sorry for the misunderstanding, as i just woke up, just saw this

image

i thought the PR got merged . its my mistake, i appologise acctually i am new to this PR related side 😓

Shariar-Hasan commented 11 months ago

hi @wingkwong i have commited some changes, can you review?

wingkwong commented 11 months ago

Next time you may click re-request review here.

image

wingkwong commented 11 months ago

Overall it looks fine. I'll have a final review tmr.

Shariar-Hasan commented 11 months ago

ok 😀 finally its done i hope.