search

wingkwong / react-quiz-component

:orange_book: React Quiz Component
https://wingkwong.github.io/react-quiz-component/
MIT License
370 stars 142 forks source link

Final Timer with styles #169

Closed vr-varad closed 9 months ago

vr-varad commented 10 months ago

@wingkwong any more changes??

vr-varad commented 10 months ago

@wingkwong sorry for being late but I have changed everything as directed. Any more changes?

wingkwong commented 10 months ago

@vr-varad Next time please click re-request review. Otherwise I won't know if you finish your changes or not. Lemme take a look now.

image

vr-varad commented 10 months ago

@wingkwong surely I will work on this. btw sent u request on discord;)

chyke007 commented 9 months ago

Overall, now it looks better.

  1. We need a prop called showTimer so that users can control to show the timer or not.
  2. We also need timer count down as well. Users should define in quiz object. The value should be in HH:MM:SS format. e.g. Finish the whole quiz under 10 mins (00:10:00). A validation needs to be done as well.

If you have any queries, please feel free to ping me at Discord (ID: wingkwong) to discuss.

Is this still worked on? As I have a working sample locally

vr-varad commented 9 months ago

I appreciate your understanding. I'm currently working on it.

wingkwong commented 9 months ago

@vr-varad I'm bit confused. I don't any updates on this PR for a while and I just found that you created another one. Does it mean the PR183 is the one I should review on?

vr-varad commented 9 months ago

Yep I made a new pr with the updated showtime feature

wingkwong commented 9 months ago

Next time please keep it in the same PR. In fact you don't need to create a new branch for every change request so that all the changes you push will be reflected here. Anyway, I'm closing this one.