winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.99k stars 196 forks source link

Redis should depend on agnostic containerization tool and not just docker #1958

Open ekeren opened 1 year ago

ekeren commented 1 year ago

Community Note

Please vote by adding a 👍 reaction to the issue to help us prioritize. If you are interested to work on this issue, please leave a comment.

Feature Spec

Our bring redis requires the user to use docker.

Maybe we should support some other pluggable mechanism that will allow the user to bring their own containerization tool

Notice the first con of @vfarcic on Klotho depending on docker here

Use Cases

Easy support for people that have Podman/LXC/rkt/CRI-O and others, considering we mainly focus early adopters, while wing is still in alpha, I think it might be relevant

Implementation Notes

From https://github.com/winglang/wing/blob/main/libs/wingsdk/src/target-sim/redis.inflight.ts, it seems that we are using docker for the following 4 actions:

  1. pull_image --image <image>
  2. start_service --port <port> --name <name>
  3. get_port --name <name>
  4. cleanup --image <image>

Component

No response

staycoolcall911 commented 1 year ago

@ekeren - thanks for reporting - I categorized this issue as p2 - let's chat if you think it should be p1.

ekeren commented 1 year ago

p2, I am aligned

github-actions[bot] commented 1 year ago

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. Feel free to re-open this issue when there's an update or relevant information to be added. Thanks!

ekeren commented 1 year ago

keep

github-actions[bot] commented 5 months ago

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. Feel free to re-open this issue when there's an update or relevant information to be added. Thanks!