Main build is failing after merging VSCode workspace PR 3929

staycoolcall911 commented 1 year ago

Incident description

After merging the following PR to main the build failed: Failed github action

We're currently looking into it and will revert if we can't find a fix soon.

Is there a workaround?

No response

Incident Response Checklist

[X] CREATE this issue (fill up the title, description and submit), then follow the next steps.
[x] PIN the incident issue.
[x] ACKNOWLEDGE the incident on PagerDuty.
[x] ACKNOWLEDGE the incident on BetterStack.
[x] WORKAROUND - if there is one, make sure it is documented in the section above.
[x] PRIORITIZE (P0/P1/P2 - see the definitions here).
[x] (optional) CONTACT a relevant person who has more information about the incident.
[x] (optional) ANNOUNCE major incidents on Slack #dev or #general channels. "NOTICE - P0 incident started. {incident-description}. Track on {link to issue}".
[x] HANDLE by reverting or forward fixing.
[x] UPDATE the team on your actions in the created #alert Slack thread throughout the incident.
[x] RESOLVE the incident on PagerDuty (BetterStack resolves automatically).
[x] UPDATE the team on the issue closure.
[x] (optional) ANNOUNCE closure of major incidents on Slack #dev or #general channels. "NOTICE - P0 incident ended. {incident-resolution-description}. Track on {link to issue}".
[x] UNPIN the incident issue.
[x] LESSONS LEARNED should be shared via the "post-mortem" workflow on #dev Slack channel.
[x] CLOSE the incident issue.

staycoolcall911 commented 1 year ago

Reverted PR #3929 via #4100

MarkMcCulloh commented 1 year ago

This issue persists intermittently, unrelated to the original trigger

Latest one here https://github.com/winglang/wing/actions/runs/6102723404/job/16561847776

Chriscbr commented 1 year ago

TypeError: Class extends value undefined is not a constructor or null
 ❯ Object.<anonymous> ../../node_modules/.pnpm/cdktf@0.17.3_constructs@10.2.70/node_modules/cdktf/lib/terraform-provider.ts:18:49
 ❯ Object.<anonymous> ../../node_modules/.pnpm/cdktf@0.17.3_constructs@10.2.70/node_modules/cdktf/lib/terraform-module.ts:5:1

@MarkMcCulloh maybe we should try unpinning the cdktf dependency in @winglang/sdk? Feels like it could be related

monadabot commented 1 year ago

Congrats! :rocket: This was released in Wing 0.29.6.

winglang / wing