Doc site search changes the browser url. Navigating to that url leads to http 404

staycoolcall911 commented 1 year ago

I tried this:

https://winglang.io/docs/
Searched for "regex" via the searchbox on top right.
Clicked "See all 4 results" at the bottom part of the quick-results panel

This happened:

Browser address bar navigated to this url: https://www.winglang.io/search?q=regex which leads to an http 404 page (not found) if I refresh the browser or click on that link.

I expected this:

Stable, bookmarkable navigation.

Is there a workaround?

No response

Component

Documentation

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Anything else?

No response

Community Notes

Please vote by adding a 👍 reaction to the issue to help us prioritize.
If you are interested to work on this issue, please leave a comment.

ainvoner commented 1 year ago

see if searchPagePath in docusaurus.config.js should be changed to docs/search

github-actions[bot] commented 11 months ago

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. Feel free to re-open this issue when there's an update or relevant information to be added. Thanks!

Chriscbr commented 11 months ago

The page that's linked (https://www.winglang.io/search?q=regex) appears to show a list of valid search results now, so it looks like this was fixed.

staycoolcall911 commented 11 months ago

Still doesn't work for me.

Chriscbr commented 11 months ago

Odd -- yeah it seems when I open the link directly it doesn't work, but if I go through the UI (type in search bar, scroll down inside the modal and click "See all results" at the bottom) then I'm taken to the page with the full results, and the page has the same URL (screenshot below) 🤔

github-actions[bot] commented 9 months ago

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. Feel free to re-open this issue when there's an update or relevant information to be added. Thanks!

garysassano commented 7 months ago

I find that using the search bar on the docsite works for me, but directly going to winglang.io/search?q=regex does not, leading me to believe the problem lies in how the server handles requests with query parameters.

garysassano commented 7 months ago

I think you need to set routing to true in InstantSearch, as explained here.

github-actions[bot] commented 4 months ago

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days. Feel free to re-open this issue when there's an update or relevant information to be added. Thanks!

staycoolcall911 commented 4 months ago

Still happens when I refresh the results page: https://www.winglang.io/search?q=regex

winglang / wing