winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.73k stars 185 forks source link

feat(sdk): add `Function.invokeAsync()` for `sim`, `tf-aws` and `awscdk` targets #4434

Closed garysassano closed 5 months ago

garysassano commented 8 months ago

Closes #1387

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

monadabot commented 8 months ago

Console preview environment is available at https://wing-console-pr-4434.fly.dev :rocket:

Last Updated (UTC) 2023-12-21 18:21
monadabot commented 8 months ago

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 72ms±0.5 | 73ms±0.74 | +1ms (+1.5%)⬜ | | jsii_big.test.w -t sim | 3400ms±16.89 | 3407ms±19.42 | +8ms (+0.23%)⬜ | | jsii_big.test.w -t tf-aws | 3508ms±17.46 | 3506ms±14.87 | -2ms (-0.05%)⬜ | | functions_1.test.w -t sim | 627ms±5.34 | 629ms±6.3 | +2ms (+0.3%)⬜ | | functions_1.test.w -t tf-aws | 1610ms±27.76 | 1628ms±42.88 | +18ms (+1.14%)⬜ | | hello_world.test.w -t sim | 626ms±5.92 | 629ms±5.2 | +3ms (+0.41%)⬜ | | hello_world.test.w -t tf-aws | 4874ms±37.36 | 4871ms±24.66 | -3ms (-0.07%)⬜ | | functions_10.test.w -t sim | 691ms±7.38 | 690ms±5.98 | -1ms (-0.13%)⬜ | | functions_10.test.w -t tf-aws | 3394ms±28.58 | 3414ms±26.33 | +20ms (+0.58%)⬜ | | jsii_small.test.w -t sim | 597ms±5.23 | 597ms±5.48 | -1ms (-0.14%)⬜ | | jsii_small.test.w -t tf-aws | 714ms±6.28 | 721ms±5.62 | +7ms (+1.03%)⬜ | | empty.test.w -t sim | 597ms±5.58 | 596ms±4.23 | -1ms (-0.13%)⬜ | | empty.test.w -t tf-aws | 705ms±5.69 | 710ms±3.5 | +5ms (+0.69%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|73ms|72ms|75ms|1ms|1ms| |jsii_big.test.w -t sim|3407ms|3384ms|3477ms|19ms|27ms| |jsii_big.test.w -t tf-aws|3506ms|3477ms|3542ms|15ms|21ms| |functions_1.test.w -t sim|629ms|606ms|637ms|6ms|9ms| |functions_1.test.w -t tf-aws|1628ms|1518ms|1709ms|43ms|60ms| |hello_world.test.w -t sim|629ms|622ms|646ms|5ms|7ms| |hello_world.test.w -t tf-aws|4871ms|4824ms|4935ms|25ms|34ms| |functions_10.test.w -t sim|690ms|676ms|701ms|6ms|8ms| |functions_10.test.w -t tf-aws|3414ms|3339ms|3461ms|26ms|37ms| |jsii_small.test.w -t sim|597ms|587ms|608ms|5ms|8ms| |jsii_small.test.w -t tf-aws|721ms|712ms|737ms|6ms|8ms| |empty.test.w -t sim|596ms|582ms|604ms|4ms|6ms| |empty.test.w -t tf-aws|710ms|701ms|718ms|4ms|5ms|
Last Updated (UTC) 2023-12-21 18:29
Chriscbr commented 7 months ago

@garysassano is this still something you're looking to work on? I wanted to check and see if there's anything I can do to help get this PR over the finish line

garysassano commented 7 months ago

@Chriscbr I'm not sure if the sim implementation functions correctly, but from what I recall, the tf-aws one worked well when I tested it.

Chriscbr commented 7 months ago

@garysassano I pushed a small update to your branch to update the docs

github-actions[bot] commented 6 months ago

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com. Feel free to re-open this PR when it is still relevant and ready to be worked on again. Thanks!

garysassano commented 6 months ago

Keep.

revitalbarletz commented 6 months ago

Hey @garysassano, do you need any assistance here?

staycoolcall911 commented 6 months ago

@revitalbarletz - FYI @Chriscbr said he'll help with this one

revitalbarletz commented 6 months ago

@Chriscbr and @garysassano can you update this PR with your status?

Chriscbr commented 6 months ago

@revitalbarletz I started working to update the PR on Friday - still want to give one more look over the tests before we merge this

mergify[bot] commented 5 months ago

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/lambda-invoke-async is up-to-date with main and the queue is empty.

monadabot commented 5 months ago

Congrats! :rocket: This was released in Wing 0.53.9.