winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.68k stars 181 forks source link

feat(sdk): add `cloud.Counter` for `tf-gcp` platform #4731

Closed garysassano closed 4 months ago

garysassano commented 7 months ago

Closes #628

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 5 months ago

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com. Feel free to re-open this PR when it is still relevant and ready to be worked on again. Thanks!

monadabot commented 5 months ago

Console preview environment is available at https://wing-console-pr-4731.fly.dev :rocket:

Last Updated (UTC) 2024-01-20 16:36
tsuf239 commented 4 months ago

Hi @garysassano, how are you? Do you need any help with this PR? Can it be reviewed again?

garysassano commented 4 months ago

@tsuf239 Cannot progress with this PR because Wing is unable to bundle certain libraries.

tsuf239 commented 4 months ago

@tsuf239 Cannot progress with this PR because Wing is unable to bundle certain libraries.

it seems not to open the right thread, can you tag me please?

garysassano commented 4 months ago

Link updated, it should work now.

tsuf239 commented 4 months ago

please pay attention to the build errors here: image

garysassano commented 4 months ago

All tests passing on GCP.

image

monadabot commented 4 months ago

Benchmarks

Comparison to Baseline 🟩⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 77ms±1.45 | 73ms±0.41 | -4ms (-5.11%)🟩 | | jsii_big.test.w -t sim | 3364ms±12.2 | 3360ms±12.23 | -4ms (-0.13%)⬜ | | jsii_big.test.w -t tf-aws | 3486ms±19.18 | 3473ms±5.49 | -13ms (-0.37%)⬜ | | functions_1.test.w -t sim | 620ms±6.08 | 623ms±6.52 | +2ms (+0.38%)⬜ | | functions_1.test.w -t tf-aws | 1824ms±79.53 | 1844ms±58.55 | +21ms (+1.13%)⬜ | | hello_world.test.w -t sim | 623ms±5.64 | 626ms±7.55 | +3ms (+0.42%)⬜ | | hello_world.test.w -t tf-aws | 4781ms±26.29 | 4815ms±34.6 | +34ms (+0.7%)⬜ | | functions_10.test.w -t sim | 682ms±6.71 | 688ms±6.69 | +6ms (+0.89%)⬜ | | functions_10.test.w -t tf-aws | 4127ms±27.61 | 4134ms±20.73 | +7ms (+0.16%)⬜ | | jsii_small.test.w -t sim | 592ms±5.43 | 604ms±7.77 | +12ms (+2.03%)⬜ | | jsii_small.test.w -t tf-aws | 711ms±5.01 | 715ms±7.01 | +3ms (+0.49%)⬜ | | empty.test.w -t sim | 592ms±7.34 | 600ms±5.93 | +8ms (+1.3%)⬜ | | empty.test.w -t tf-aws | 710ms±7.49 | 715ms±6.47 | +5ms (+0.67%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|73ms|72ms|74ms|0ms|1ms| |jsii_big.test.w -t sim|3360ms|3332ms|3385ms|12ms|17ms| |jsii_big.test.w -t tf-aws|3473ms|3463ms|3486ms|5ms|8ms| |functions_1.test.w -t sim|623ms|605ms|634ms|7ms|9ms| |functions_1.test.w -t tf-aws|1844ms|1713ms|1984ms|59ms|82ms| |hello_world.test.w -t sim|626ms|613ms|652ms|8ms|11ms| |hello_world.test.w -t tf-aws|4815ms|4752ms|4918ms|35ms|48ms| |functions_10.test.w -t sim|688ms|676ms|704ms|7ms|9ms| |functions_10.test.w -t tf-aws|4134ms|4098ms|4184ms|21ms|29ms| |jsii_small.test.w -t sim|604ms|589ms|619ms|8ms|11ms| |jsii_small.test.w -t tf-aws|715ms|701ms|728ms|7ms|10ms| |empty.test.w -t sim|600ms|581ms|612ms|6ms|8ms| |empty.test.w -t tf-aws|715ms|699ms|728ms|6ms|9ms|
Last Updated (UTC) 2024-01-20 16:44
mergify[bot] commented 4 months ago

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/sdk-counter-gcp is up-to-date with main and the queue is empty.

mergify[bot] commented 4 months ago

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/sdk-counter-gcp is up-to-date with main and the queue is empty.

staycoolcall911 commented 4 months ago

@garysassano - can you please resolve the conflicts? The PR should then merge to main automatically. LMK if you run into any issues and I'll help so we could close this, thanks!

mergify[bot] commented 4 months ago

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/sdk-counter-gcp is up-to-date with main and the queue is empty.

monadabot commented 4 months ago

Congrats! :rocket: This was released in Wing 0.54.46.