fix(sdk): container does not listen to port

skyrpex commented 2 weeks ago

This change uses waitUntil after the docker container is up and running to ensure that the hostPort is correctly retrieved, as there seems to be a small time window when the container is running but the host port is not specified.

Fixes #6371

github-actions[bot] commented 2 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic	Owner
Wing SDK and utility APIs	`@chriscbr`
Wing Console	`@ainvoner`, `@skyrpex`, `@polamoros`
JSON, structs, primitives and collections	`@hasanaburayyan`
Platforms and plugins	`@hasanaburayyan`
Frontend resources (website, react, etc)	`@tsuf239`
Language design	`@chriscbr`
VSCode extension and language server	`@markmcculloh`
Compiler architecture, inflights, lifting	`@yoav-steinberg`
Wing Testing Framework	`@tsuf239`
Wing CLI	`@markmcculloh`
Build system, dev environment, releases	`@markmcculloh`
Library Ecosystem	`@chriscbr`
Documentation	`@hasanaburayyan`
SDK test suite	`@tsuf239`
Examples	`@hasanaburayyan`
Wing Playground	`@eladcon`

monadabot commented 2 weeks ago

Console preview environment is available at https://wing-console-pr-6372.fly.dev :rocket:

Last Updated (UTC) 2024-04-29 08:15

monadabot commented 2 weeks ago

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜

| Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 57ms±0.37 | 58ms±0.74 | +1ms (+2.41%)⬜ | | functions_1.test.w -t sim | 398ms±5.71 | 404ms±5.24 | +5ms (+1.35%)⬜ | | functions_1.test.w -t tf-aws | 824ms±5.53 | 823ms±8.1 | -1ms (-0.09%)⬜ | | jsii_big.test.w -t sim | 2814ms±31.16 | 2799ms±10.29 | -14ms (-0.51%)⬜ | | jsii_big.test.w -t tf-aws | 3020ms±17.29 | 3005ms±10.63 | -15ms (-0.49%)⬜ | | functions_10.test.w -t sim | 477ms±12.99 | 488ms±7.05 | +11ms (+2.27%)⬜ | | functions_10.test.w -t tf-aws | 2025ms±19.64 | 2033ms±14.9 | +9ms (+0.42%)⬜ | | jsii_small.test.w -t sim | 374ms±2.92 | 369ms±3.42 | -5ms (-1.4%)⬜ | | jsii_small.test.w -t tf-aws | 608ms±5.57 | 610ms±3.93 | +2ms (+0.3%)⬜ | | empty.test.w -t sim | 359ms±4.42 | 361ms±3.45 | +2ms (+0.55%)⬜ | | empty.test.w -t tf-aws | 594ms±5.01 | 594ms±3 | 0ms (-0.01%)⬜ | | hello_world.test.w -t sim | 395ms±3.64 | 400ms±3.86 | +5ms (+1.35%)⬜ | | hello_world.test.w -t tf-aws | 1513ms±5.47 | 1528ms±14.38 | +15ms (+0.99%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._

Results

|name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|58ms|57ms|60ms|1ms|1ms| |functions_1.test.w -t sim|404ms|390ms|417ms|5ms|7ms| |functions_1.test.w -t tf-aws|823ms|806ms|846ms|8ms|11ms| |jsii_big.test.w -t sim|2799ms|2782ms|2827ms|10ms|14ms| |jsii_big.test.w -t tf-aws|3005ms|2983ms|3026ms|11ms|15ms| |functions_10.test.w -t sim|488ms|473ms|501ms|7ms|10ms| |functions_10.test.w -t tf-aws|2033ms|1993ms|2056ms|15ms|21ms| |jsii_small.test.w -t sim|369ms|361ms|376ms|3ms|5ms| |jsii_small.test.w -t tf-aws|610ms|602ms|621ms|4ms|6ms| |empty.test.w -t sim|361ms|355ms|370ms|3ms|5ms| |empty.test.w -t tf-aws|594ms|586ms|603ms|3ms|4ms| |hello_world.test.w -t sim|400ms|393ms|407ms|4ms|5ms| |hello_world.test.w -t tf-aws|1528ms|1502ms|1573ms|14ms|20ms|

Last Updated (UTC) 2024-04-29 08:20

mergify[bot] commented 2 weeks ago

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if fix-container-does-not-listen-to-port is up-to-date with main and the queue is empty.

monadabot commented 2 weeks ago

Congrats! :rocket: This was released in Wing 0.73.8.

winglang / wing